[asterisk-bugs] [LibPRI 0017360]: [patch] LibPRI problem with restart of PBX processor (Testing SVN 1688)

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17360 
====================================================================== 
Reported By:                shawkris
Assigned To:                rmudgett
====================================================================== 
Project:                    LibPRI
Issue ID:                   17360
Category:                   General
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.30 
JIRA:                       SWP-1680 
libpri Version:             I did not set the version. :( 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 1688 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2010-05-19 07:57 CDT
Last Modified:              2010-09-07 19:13 CDT
====================================================================== 
Summary:                    [patch] LibPRI problem with restart of PBX processor
(Testing SVN 1688)
Description: 
Asterisk is connected to legacy Siemens PBX. PBX has dual CPU and switches
over active/passive processors at (or close to) 00:00.

During the switchover, the link stays up but the PBX sends SABME. Asterisk
should clear state to restart q921. A few seconds after the first call
comes in, we see the legacy PBX drops the link and tries to re-establish -
it normally does this after a protocol error (timer expiry etc).

I will try and reproduce with pri debugging enabled.
====================================================================== 

---------------------------------------------------------------------- 
 (0126728) svnbot (reporter) - 2010-09-07 19:13
 https://issues.asterisk.org/view.php?id=17360#c126728 
---------------------------------------------------------------------- 
Repository: libpri
Revision: 1962

U   branches/1.4/q921.c
U   branches/1.4/q931.c

------------------------------------------------------------------------
r1962 | rmudgett | 2010-09-07 19:13:24 -0500 (Tue, 07 Sep 2010) | 21 lines

Made Q.921 delay events to Q.931 if the event could immediately generate
response frames.

Q.921 was passing a q931_dl_indication(up) event to Q.931 before it was
finished processing the frame.  The q931_dl_indication(up) event could
immediately send STATUS messages in the Q.921 intermediate state that
would then get stuck in the tx queue with an invalid N(S).

Q.921 was passing i-frames to Q.931 before it was finished processing the
frame.  The i-frames could cause Q.931 to immediately generate a response
message that may cause the peer to see the P/F bit as incorrect.

Delayed passing q931_dl_indication(up) events and i-frames to Q.931 until
Q.921 has completed processing the frame event.  (The Q.921 SDL diagrams
were designed with this assumption.)

(closes issue https://issues.asterisk.org/view.php?id=17360)
Reported by: shawkris
Patches:
      issue17360_v1.4.patch uploaded by rmudgett (license 664)
Tested by: shawkris, rmudgett

------------------------------------------------------------------------

http://svn.digium.com/view/libpri?view=rev&revision=1962 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-09-07 19:13 svnbot         Note Added: 0126728                          
======================================================================