[asterisk-bugs] [Asterisk 0017192]: [patch] Phone keeps ringing when hangup between 'NOTIFY' and 'Status: 180 Ringing'

[Asterisk Bug Tracker]

The following issue requires your FEEDBACK. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17192 
====================================================================== 
Reported By:                ronaldderksen
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17192
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.6.0.26 
JIRA:                       SWP-1350 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.0 
SVN Revision (number only!): 257592 
Request Review:              
====================================================================== 
Date Submitted:             2010-04-16 04:49 CDT
Last Modified:              2010-09-07 15:19 CDT
====================================================================== 
Summary:                    [patch] Phone keeps ringing when hangup between
'NOTIFY' and 'Status: 180 Ringing'
Description: 
When I call my aastra SIP phone and hangup before the aastra phone sents
back the 'Status: 180 Ringing' the phone keeps ringing 'forever'
This is what I see with tshark when I hangup right after I dialed the
phone.

  0.000000 192.168.12.4 -> 192.168.12.100 SIP Request: NOTIFY
sip:400 at 192.168.12.100:5060;transport=udp
  0.044154 192.168.12.100 -> 192.168.12.4 SIP Status: 200 OK
  0.351948 192.168.12.4 -> 192.168.12.100 SIP/SDP Request: INVITE
sip:400 at 192.168.12.100:5060;transport=udp, with session description
  0.355715 192.168.12.4 -> 192.168.12.100 SIP Request: NOTIFY
sip:400 at 192.168.12.100:5060;transport=udp
  0.525349 192.168.12.100 -> 192.168.12.4 SIP Status: 180 Ringing
  0.529074 192.168.12.100 -> 192.168.12.4 SIP Status: 200 OK

The aastra phone sents the 'Status: 180 Ringing' message after 529ms. That
is a a big window. When I first play a message with 'Playback' application
and the caller decides to hangup, the window of 529ms is too much. There is
a big change people hangup in that 529ms.

I can also reproduce this with a polycom phone. But with polucom it is
harder because it sents the 'Status: 180 Ringing' quicker (186 ms) I cannot
reproduce this problem with a linksys phone. Linksys phone sents the
'Status: 180 Ringing' in 20ms.

A normal Dial -> ringing -> hangup looks like this (with aastra phone):

  0.000000 192.168.12.4 -> 192.168.12.100 SIP Request: NOTIFY
sip:400 at 192.168.12.100:5060;transport=udp
  0.047770 192.168.12.100 -> 192.168.12.4 SIP Status: 200 OK
  0.331322 192.168.12.4 -> 192.168.12.100 SIP/SDP Request: INVITE
sip:400 at 192.168.12.100:5060;transport=udp, with session description
  0.464797 192.168.12.100 -> 192.168.12.4 SIP Status: 180 Ringing
  2.822520 192.168.12.4 -> 192.168.12.100 SIP Request: NOTIFY
sip:400 at 192.168.12.100:5060;transport=udp
  2.823327 192.168.12.4 -> 192.168.12.100 SIP Request: CANCEL
sip:400 at 192.168.12.100:5060;transport=udp
  2.983367 192.168.12.100 -> 192.168.12.4 SIP Status: 200 OK
  2.986478 192.168.12.100 -> 192.168.12.4 SIP Status: 487 Request
Terminated

So When I hangup after the phone ringed ones, I see that asterisk sents a
'CANCEL' message. I think this 'CANCEL' message also need to be sent when
asterisk did not yet receive the 'Status: 180 Ringing' message.

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0017096 C keeps ringing when hanging A and B af...
related to          0013626 [patch] CANCEL before Trying
====================================================================== 

---------------------------------------------------------------------- 
 (0126693) lmadsen (administrator) - 2010-09-07 15:19
 https://issues.asterisk.org/view.php?id=17192#c126693 
---------------------------------------------------------------------- 
Requested feedback after testing patch from reviewboard. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-09-07 15:19 lmadsen        Note Added: 0126693                          
2010-09-07 15:19 lmadsen        Status                   acknowledged =>
feedback
======================================================================