[asterisk-bugs] [Asterisk 0017678]: Fix select() usage in Asterisk

Thu Sep 2 00:02:55 CDT 2010

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17678 
====================================================================== 
Reported By:                russell
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   17678
Category:                   Core/General
Reproducibility:            N/A
Severity:                   crash
Priority:                   normal
Status:                     closed
Target Version:             1.8.0
Asterisk Version:           SVN 
JIRA:                       SWP-1882 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 278479 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-07-21 11:31 CDT
Last Modified:              2010-09-02 00:02 CDT
====================================================================== 
Summary:                    Fix select() usage in Asterisk
Description: 
The following commit fixes an error with the usage of select():

http://lists.digium.com/pipermail/asterisk-commits/2010-July/044279.html

This same problem exists in other places in the code.  All uses of
select() need to be audited and fixed as appropriate.
====================================================================== 

---------------------------------------------------------------------- 
 (0126551) svnbot (reporter) - 2010-09-02 00:02
 https://issues.asterisk.org/view.php?id=17678#c126551 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 284598

_U  trunk/
U   trunk/addons/ooh323c/src/ooSocket.h
U   trunk/addons/ooh323c/src/oochannels.c
U   trunk/channels/chan_misdn.c
U   trunk/channels/chan_phone.c
U   trunk/channels/chan_usbradio.c
U   trunk/channels/console_video.c
U   trunk/configure
U   trunk/configure.ac
U   trunk/include/asterisk/autoconfig.h.in
U   trunk/include/asterisk/channel.h
U   trunk/include/asterisk/poll-compat.h
A   trunk/include/asterisk/select.h
U   trunk/main/asterisk.c
U   trunk/main/features.c
U   trunk/main/poll.c
U   trunk/main/stun.c
U   trunk/res/res_ais.c
U   trunk/res/res_jabber.c
U   trunk/res/res_pktccops.c
A   trunk/tests/test_poll.c

------------------------------------------------------------------------
r284598 | tilghman | 2010-09-02 00:02:55 -0500 (Thu, 02 Sep 2010) | 36
lines

Merged revisions 284597 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
  r284597 | tilghman | 2010-09-02 00:00:34 -0500 (Thu, 02 Sep 2010) | 29
lines

  Merged revisions 284593,284595 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.6.2

  ................
    r284593 | tilghman | 2010-09-01 17:59:50 -0500 (Wed, 01 Sep 2010) | 18
lines

    Merged revisions 284478 via svnmerge from 
    https://origsvn.digium.com/svn/asterisk/branches/1.4

    ........
      r284478 | tilghman | 2010-09-01 13:49:11 -0500 (Wed, 01 Sep 2010) |
11 lines

      Ensure that all areas that previously used select(2) now use
poll(2), with implementations that need poll(2) implemented with select(2)
safe against 1024-bit overflows.

      This is a followup to the fix for the pthread timer in 1.6.2 and
beyond, fixing
      a potential crash bug in all supported releases.

      (closes issue https://issues.asterisk.org/view.php?id=17678)
       Reported by: russell
      Branch:
https://origsvn.digium.com/svn/asterisk/team/tilghman/ast_select 

      Review: https://reviewboard.asterisk.org/r/824/
    ........
  ................
    r284595 | tilghman | 2010-09-01 22:57:43 -0500 (Wed, 01 Sep 2010) | 2
lines

    Failed to rerun bootstrap.sh after last commit
  ................
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=284598 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-09-02 00:02 svnbot         Checkin                                      
2010-09-02 00:02 svnbot         Note Added: 0126551                          
======================================================================