[asterisk-bugs] [Asterisk 0017678]: Fix select() usage in Asterisk

Asterisk Bug Tracker noreply at bugs.digium.com
Wed Sep 1 17:59:51 CDT 2010


A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17678 
====================================================================== 
Reported By:                russell
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   17678
Category:                   Core/General
Reproducibility:            N/A
Severity:                   crash
Priority:                   normal
Status:                     closed
Target Version:             1.8.0
Asterisk Version:           SVN 
JIRA:                       SWP-1882 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 278479 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-07-21 11:31 CDT
Last Modified:              2010-09-01 17:59 CDT
====================================================================== 
Summary:                    Fix select() usage in Asterisk
Description: 
The following commit fixes an error with the usage of select():

http://lists.digium.com/pipermail/asterisk-commits/2010-July/044279.html

This same problem exists in other places in the code.  All uses of
select() need to be audited and fixed as appropriate.
====================================================================== 

---------------------------------------------------------------------- 
 (0126544) svnbot (reporter) - 2010-09-01 17:59
 https://issues.asterisk.org/view.php?id=17678#c126544 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 284593

_U  branches/1.6.2/
U   branches/1.6.2/channels/chan_misdn.c
U   branches/1.6.2/channels/chan_phone.c
U   branches/1.6.2/channels/chan_usbradio.c
U   branches/1.6.2/channels/console_video.c
U   branches/1.6.2/configure.ac
U   branches/1.6.2/include/asterisk/channel.h
U   branches/1.6.2/include/asterisk/poll-compat.h
A   branches/1.6.2/include/asterisk/select.h
U   branches/1.6.2/main/asterisk.c
U   branches/1.6.2/main/features.c
U   branches/1.6.2/main/poll.c
U   branches/1.6.2/main/rtp.c
U   branches/1.6.2/res/res_ais.c
U   branches/1.6.2/res/res_jabber.c
A   branches/1.6.2/tests/test_poll.c
U   branches/1.6.2/utils/clicompat.c

------------------------------------------------------------------------
r284593 | tilghman | 2010-09-01 17:59:51 -0500 (Wed, 01 Sep 2010) | 18
lines

Merged revisions 284478 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r284478 | tilghman | 2010-09-01 13:49:11 -0500 (Wed, 01 Sep 2010) | 11
lines
  
  Ensure that all areas that previously used select(2) now use poll(2),
with implementations that need poll(2) implemented with select(2) safe
against 1024-bit overflows.
  
  This is a followup to the fix for the pthread timer in 1.6.2 and beyond,
fixing
  a potential crash bug in all supported releases.
  
  (closes issue https://issues.asterisk.org/view.php?id=17678)
   Reported by: russell
  Branch: https://origsvn.digium.com/svn/asterisk/team/tilghman/ast_select

  
  Review: https://reviewboard.asterisk.org/r/824/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=284593 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-09-01 17:59 svnbot         Checkin                                      
2010-09-01 17:59 svnbot         Note Added: 0126544                          
======================================================================




More information about the asterisk-bugs mailing list