[asterisk-bugs] [Asterisk 0018089]: [patch] Call files generate two warning logs after each successful completion

[Asterisk Bug Tracker]

The following issue is now READY FOR TESTING. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18089 
====================================================================== 
Reported By:                abelbeck
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   18089
Category:                   PBX/pbx_spool
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           SVN 
JIRA:                       SWP-2335 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-10-04 10:52 CDT
Last Modified:              2010-10-21 17:16 CDT
====================================================================== 
Summary:                    [patch] Call files generate two warning logs after
each successful completion
Description: 
Call files with 1.8-rc2 with Issue https://issues.asterisk.org/view.php?id=17924
patch works for me.

The problem reported here are two warning logs that are generated for each
successful call file.  (See Additional Information)

Each warning log occurs at "RetryTime" seconds after the call-file
completion or previous warning log.

While these warnings seem harmless, it indicates the queue is maintaining
multiple instances of the call file, (or inotify is generating them during
the processing).

If HAVE_INOTIFY is undefined in pbx_spool.c, the problem goes away.

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0017924 [patch] Call file errors in Asterisk 1....
related to          0017337 [patch] [regression] flooding /var/spoo...
====================================================================== 

---------------------------------------------------------------------- 
 (0128303) tilghman (administrator) - 2010-10-21 17:16
 https://issues.asterisk.org/view.php?id=18089#c128303 
---------------------------------------------------------------------- 
Patch uploaded that solves the problem for me.  The issue was in the
transition from IN_CREATE to IN_CLOSE_WRITE, it was ignored that we write
several times to the callfile while it is in-queue.  When we wrote to the
callfile, IN_CLOSE_WRITE forced the file to be requeued erroneously.  This
has been fixed by requiring an IN_CREATE before IN_CLOSE_WRITE, such that
subsequent writes are ignored. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-10-21 17:16 tilghman       Asterisk Version         1.8.0-rc2 => SVN    
2010-10-21 17:16 tilghman       Note Added: 0128303                          
2010-10-21 17:16 tilghman       Assigned To              jpeeler => tilghman 
2010-10-21 17:16 tilghman       Status                   assigned => ready for
testing
======================================================================