[asterisk-bugs] [DAHDI-linux 0016894]: fwringdetect option is ineffective

[Asterisk Bug Tracker]

The following issue has been ASSIGNED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16894 
====================================================================== 
Reported By:                rde42
Assigned To:                sruffell
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   16894
Category:                   wctdm24xxp
Reproducibility:            N/A
Severity:                   major
Priority:                   normal
Status:                     assigned
JIRA:                        
Reviewboard Link:            
====================================================================== 
Date Submitted:             2010-02-24 08:51 CST
Last Modified:              2010-10-20 07:23 CDT
====================================================================== 
Summary:                    fwringdetect option is ineffective
Description: 
The fwringdetect option does not set registers correctly. This code, from
line 2256 onwards, does not make sense:

	if(fwringdetect || neonmwi_monitor) {
		/* Enable ring detector full-wave rectifier mode */
		wctdm_setreg(wc, card, 18, 2);
		wctdm_setreg(wc, card, 24, 0);
	} else { 
		/* Set to the device defaults */
		wctdm_setreg(wc, card, 18, 0);
		wctdm_setreg(wc, card, 24, 0x19);
	}
	
	/* Enable ring detector full-wave rectifier mode */
	wctdm_setreg(wc, card, 18, 2);
	wctdm_setreg(wc, card, 24, 0);

The last two statements nullify the 'if' statement above, since they
repeat the settings in the 'true' branch.

The effect for me (in the UK) was that the card would not detect a ring
condition. Removal of those two lines allowed ring to be detected.
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-10-20 07:23 svnbot         Status                   acknowledged =>
assigned
======================================================================