[asterisk-bugs] [DAHDI-linux 0016894]: fwringdetect option is ineffective

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16894 
====================================================================== 
Reported By:                rde42
Assigned To:                sruffell
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   16894
Category:                   wctdm24xxp
Reproducibility:            N/A
Severity:                   major
Priority:                   normal
Status:                     acknowledged
JIRA:                        
Reviewboard Link:            
====================================================================== 
Date Submitted:             2010-02-24 08:51 CST
Last Modified:              2010-10-20 07:23 CDT
====================================================================== 
Summary:                    fwringdetect option is ineffective
Description: 
The fwringdetect option does not set registers correctly. This code, from
line 2256 onwards, does not make sense:

	if(fwringdetect || neonmwi_monitor) {
		/* Enable ring detector full-wave rectifier mode */
		wctdm_setreg(wc, card, 18, 2);
		wctdm_setreg(wc, card, 24, 0);
	} else { 
		/* Set to the device defaults */
		wctdm_setreg(wc, card, 18, 0);
		wctdm_setreg(wc, card, 24, 0x19);
	}
	
	/* Enable ring detector full-wave rectifier mode */
	wctdm_setreg(wc, card, 18, 2);
	wctdm_setreg(wc, card, 24, 0);

The last two statements nullify the 'if' statement above, since they
repeat the settings in the 'true' branch.

The effect for me (in the UK) was that the card would not detect a ring
condition. Removal of those two lines allowed ring to be detected.
====================================================================== 

---------------------------------------------------------------------- 
 (0128226) svnbot (reporter) - 2010-10-20 07:23
 https://issues.asterisk.org/view.php?id=16894#c128226 
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 9441

U   linux/trunk/drivers/dahdi/wctdm24xxp/base.c

------------------------------------------------------------------------
r9441 | sruffell | 2010-10-20 07:23:03 -0500 (Wed, 20 Oct 2010) | 15 lines

wctdm24xxp: Leave FXO (DAA) always in full-wave ring detect mode.

In zaptel commit 4096 [1], all the debouncing of ring signals were moved
into software as opposed to using the ring validation circuit in DAA.
That commit failed to remove the initial check and set of the ring
validation circuit.

[1] http://svn.digium.com/view/zaptel?view=revision&revision=4096

(closes issue https://issues.asterisk.org/view.php?id=16894)
Reported by: rde42

Signed-off-by: Shaun Ruffell <sruffell at digium.com>
Acked-by: Kinsey Moore <kmoore at digium.com>
Acked-by: Russ Meyerriecks <rmeyerriecks at digium.com>
------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=9441 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-10-20 07:23 svnbot         Checkin                                      
2010-10-20 07:23 svnbot         Note Added: 0128226                          
======================================================================