[asterisk-bugs] [Asterisk 0018162]: deny=all in iax.conf results in segmentation fault

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18162 
====================================================================== 
Reported By:                imcdona
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18162
Category:                   Channels/chan_iax2
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     new
Asterisk Version:           1.8.0-rc5 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-10-19 05:18 CDT
Last Modified:              2010-10-19 06:22 CDT
====================================================================== 
Summary:                    deny=all in iax.conf results in segmentation fault
Description: 
Specifying deny=all rather than disallow=all in the codec directive on an
IAX peer results in a seg fault. Changing deny=all to disallow=all results
in expected behavior.

Example improper use of the codec directive that causes a crash:
[bobloblaw]
deny=all
allow=ulaw
type=friend
host=172.20.20.5
qualify=yes
context=from-internal

Example of proper use of the codec directive that does not cause a crash:
[bobloblaw]
disallow=all
allow=ulaw
type=friend
host=172.20.20.5
qualify=yes
context=from-internal

====================================================================== 

---------------------------------------------------------------------- 
 (0128191) wdoekes (reporter) - 2010-10-19 06:22
 https://issues.asterisk.org/view.php?id=18162#c128191 
---------------------------------------------------------------------- 
ast_append_ha expects a valid *error pointer to be passed. Several callers
do not provide it:

./main/manager.c:user->ha = ast_append_ha(var->name, var->value, user->ha,
NULL);
./channels/chan_skinny.c:CDEV->ha = ast_append_ha(v->name, v->value,
CDEV->ha, NULL);
./channels/chan_iax2.c:peer->ha = ast_append_ha(v->name, v->value,
peer->ha, NULL);
./channels/chan_iax2.c:user->ha = ast_append_ha(v->name, v->value,
user->ha, NULL);
./channels/chan_mgcp.c:gw->ha = ast_append_ha(v->name, v->value, gw->ha,
NULL);
./channels/chan_unistim.c:d->ha = ast_append_ha(v->name, v->value, d->ha,
NULL);

Fix: either allow *error to be NULL in ast_append_ha or fix the above to
supply an &error location. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-10-19 06:22 wdoekes        Note Added: 0128191                          
======================================================================