[asterisk-bugs] [Asterisk 0018044]: [patch] Crash in check_sounds

[Asterisk Bug Tracker]

The following issue has been RESOLVED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18044 
====================================================================== 
Reported By:                murf
Assigned To:                lmadsen
====================================================================== 
Project:                    Asterisk
Issue ID:                   18044
Category:                   Sounds
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     resolved
Asterisk Version:           1.6.2.14-rc1 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-09-23 23:37 CDT
Last Modified:              2010-10-18 14:17 CDT
====================================================================== 
Summary:                    [patch] Crash in check_sounds
Description: 
When I demo'd this for an interested party, it crashed!
So I took some time and debugged it. Simply, I got confused
on which variable to use as the file count. I was using numents,
but should have been using 'ind'. So I fixed it, and added an 
extra printf to say how many actual files were in the list (it
does tell you how many entries are in the script file.). No more
crashes on stock script files issued for 1.4.19 (core).

Now, I also added code so it will ignore comment lines that start with a
';' in the
first char of the line.

I suggest we mod the script files to follow the above format for 
comments. It will make running the checks easier.

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0017473 [patch] mistakes in the 1.4.19 core-sou...
====================================================================== 

---------------------------------------------------------------------- 
 (0128169) svnbot (reporter) - 2010-10-18 14:17
 https://issues.asterisk.org/view.php?id=18044#c128169 
---------------------------------------------------------------------- 
Repository: repotools
Revision: 744

U   sound_tools/scripts/check_sounds.c

------------------------------------------------------------------------
r744 | lmadsen | 2010-10-18 14:17:50 -0500 (Mon, 18 Oct 2010) | 7 lines

Don't crash when checking sound files.

(closes issue https://issues.asterisk.org/view.php?id=18044)
Reported by: murf
Patches:
      check_sounds.c.patch uploaded by murf (license 722)
Tested by: murf
------------------------------------------------------------------------

http://svn.digium.com/view/repotools?view=rev&revision=744 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-10-18 14:17 svnbot         Note Added: 0128169                          
2010-10-18 14:17 svnbot         Status                   ready for testing =>
assigned
2010-10-18 14:17 svnbot         Status                   assigned => resolved
2010-10-18 14:17 svnbot         Resolution               open => fixed       
======================================================================