[asterisk-bugs] [Asterisk 0018116]: [patch] [regression] faxdetect now must apply to all dahdi channels; change from 1.6.2.x

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18116 
====================================================================== 
Reported By:                seandarcy
Assigned To:                rmudgett
====================================================================== 
Project:                    Asterisk
Issue ID:                   18116
Category:                   Applications/app_fax
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     feedback
Target Version:             1.8.0
Asterisk Version:           1.8.0-rc3 
JIRA:                       SWP-2355 
Regression:                 Yes 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-10-11 14:34 CDT
Last Modified:              2010-10-13 15:21 CDT
====================================================================== 
Summary:                    [patch] [regression] faxdetect now must apply to all
dahdi channels; change from 1.6.2.x
Description: 
In 1.6.2.x you could place faxdetect = <whatever> anyplace before the
channel you wanted it to apply to. Now it appears it must apply globally.


====================================================================== 

---------------------------------------------------------------------- 
 (0127982) svnbot (reporter) - 2010-10-13 15:21
 https://issues.asterisk.org/view.php?id=18116#c127982 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 291541

U   branches/1.8/channels/chan_dahdi.c

------------------------------------------------------------------------
r291541 | rmudgett | 2010-10-13 15:21:04 -0500 (Wed, 13 Oct 2010) | 26
lines

The chan_dahdi faxdetect option only works for the first FAX call.

The chan_dahdi faxdetect option only works for the first call.  After that
the option no longer works.  The struct dahdi_pvt.callprogress member is
the encoded user config setting for the callprogress and faxdetect config
options.  Changing this value alters the configuration for all following
calls until the chan_dahdi.conf file is reloaded.

* Fixed the chan_dahdi ast_channel_setoption callback to not change the
users faxdetect config setting except for the current call.

* Fixed the chan_dahdi ast_channel_queryoption callback to read the active
DSP setting of the faxdetect option.

* Made actually disable the active faxdetect DSP setting for the current
call on the analog port.  my_handle_dtmfup() is used for normal analog
ports.  dahdi_handle_dtmfup() is the legacy code and is no longer used
unless in a radio mode.

(closes issue https://issues.asterisk.org/view.php?id=18116)
Reported by: seandarcy
Patches:
      issue18116_v1.8.patch uploaded by rmudgett (license 664)

Review: https://reviewboard.asterisk.org/r/972/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=291541 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-10-13 15:21 svnbot         Note Added: 0127982                          
======================================================================