[asterisk-bugs] [Asterisk 0018112]: [patch] Report what extension called a failed macro

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18112 
====================================================================== 
Reported By:                prado
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18112
Category:                   Applications/app_macro
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     ready for review
Asterisk Version:           SVN 
JIRA:                       SWP-2354 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-10-08 19:08 CDT
Last Modified:              2010-10-13 03:58 CDT
====================================================================== 
Summary:                    [patch] Report what extension called a failed macro
Description: 
Suppose some extension calls a macro, but the macro was removed, renamed or
it's name is incorrect. The log shows:

[Oct  8 17:51:36] WARNING[3070] app_macro.c: No such context 'macro-disca'
for macro 'disca'.

It's difficult to tell by the log what extension called the macro.
Specially if you have a big dialplan with lots of includes.



I propose a change, so the macro also shows who called it.
With the change, the log will show:

WARNING[3070] app_macro.c: No such context 'macro-disca' for macro
'disca'. Was called by 114194 at default


Now it's easier to track the error and make the adjustments on the
dialplan because we know we have to fix extension 114194 at default.
It's simple, but I think it's very useful.
What do you think?

I did a patch agains trunk. How can I upload it here?












 


====================================================================== 

---------------------------------------------------------------------- 
 (0127931) svnbot (reporter) - 2010-10-13 03:58
 https://issues.asterisk.org/view.php?id=18112#c127931 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 291361

U   trunk/apps/app_macro.c

------------------------------------------------------------------------
r291361 | schmitds | 2010-10-13 03:58:42 -0500 (Wed, 13 Oct 2010) | 11
lines

Report what extension called a failed macro

Add the extension and context of the calling channel to the log output if
a macro could not be found.

(closes issue https://issues.asterisk.org/view.php?id=18112)
Reported by: prado
Patches: 
	app_macro-info.diff uploaded by prado (license 510)
Tested by: schmidts


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=291361 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-10-13 03:58 svnbot         Checkin                                      
2010-10-13 03:58 svnbot         Note Added: 0127931                          
======================================================================