[asterisk-bugs] [Asterisk 0018091]: [patch] dialgroup fills database with duplicates

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18091 
====================================================================== 
Reported By:                bunny
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   18091
Category:                   Functions/func_dialgroup
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     ready for review
Asterisk Version:           1.6.2.11 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-10-04 20:37 CDT
Last Modified:              2010-10-11 11:32 CDT
====================================================================== 
Summary:                    [patch] dialgroup fills database with duplicates
Description: 
every time a dialgroup is called, it appends to the astdb resulting in a
ridiculous number of repeats. It is, however, sorting the duplicates.

example usage:
http://www.asterisk.org/docs/asterisk/trunk/functions/dialgroup
http://www.voip-info.org/wiki/view/Asterisk+func+dialgroup

Either the way to use dialgroup is violently wrong or there is a bug in
how stuff works.

After a while, you end up with:

/dialgroup/5f                                     :
SIP/500 at phone-521.office&SIP/500 at phone-521.office&SIP/500 at phone-521.office
&SIP/500 at phone-521.office&SIP/500 at phone-521.office&SIP/500 at phone-521.office
&SIP/500 at phone-521.office&SIP/500 at phone-521.office&SIP/500 at phone-521.office
&SIP/500 at phone-521.office&SIP/500 at phone-521.office&SIP/500 at phone-521.office
&SIP/500 at phone-521.office&SIP/500 at phone-521.office&SIP/500 at phone-521.office
&SIP/500 at phone-521.office&SIP/500 at phone-521.office&SIP/500 at phone-521.office
...
&SIP/500 at phone-521.office&SIP/500 at phone-521.office&SIP/500 at phone-521.office
&SIP/500 at phone-521.office&SIP/500 at phone-521.office&SIP/500 at phone-521.office
&SIP/500 at phone-521.office&SIP/500 at phone-521.office&SIP/500 at phone-512.office
&SIP/500 at phone-513.office&SIP/500 at phone-512.office&SIP/500 at phon...


database deltree dialgroup/5f also lies about its success.

====================================================================== 

---------------------------------------------------------------------- 
 (0127840) tilghman (administrator) - 2010-10-11 11:32
 https://issues.asterisk.org/view.php?id=18091#c127840 
---------------------------------------------------------------------- 
<i>As the Dial( all these phones ) soon becomes unmanageable.</i>

An alternate method of doing that would be to define a variable in the
[globals] section of extensions.conf, then reference that variable anytime
you need a particular set of phones.  For that matter, you can still use
DIALGROUP() in this way, but think of the set of phones as a set of dynamic
items that individuals can remove themselves from (or add themselves to) as
the situation warrants. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-10-11 11:32 tilghman       Note Added: 0127840                          
======================================================================