[asterisk-bugs] [DAHDI-linux 0015173]: [patch] dahdi_dialparams fields are inconsistent

[Asterisk Bug Tracker]

The following issue has been UPDATED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15173 
====================================================================== 
Reported By:                dimas
Assigned To:                
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   15173
Category:                   General
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     confirmed
JIRA:                        
Reviewboard Link:            
====================================================================== 
Date Submitted:             2009-05-21 13:54 CDT
Last Modified:              2010-10-07 11:49 CDT
====================================================================== 
Summary:                    [patch] dahdi_dialparams fields are inconsistent
Description: 
DISCLAIMER
The patch is "theoreticsl" - I just checked it compiles but I can not even
test it because I'm not using DAHDI but currently running on Zaptel
instead.

While I believe the patch is right, I'm not saying it is the exact changes
that needs to be applied. It is more like an illustration to a DAHDI
developer with a proposed fix to the problem I discovered.
END OF DISCLAIMER

I found that fields of global_dialparams like dtmf_tonelen may be a bit
inconsistent - these are initialized with DEFAULT_DTMF_LENGTH which is
length in samples but when userspace uses DAHDI_SET_DIALPARAMS ioctl, to
set the desired value, the same field receives duration in milliseconds.
The ioctl_load_zone expects these fields to be length in samples thougt...

The patch tries to remove this inconsistency by making sure that these
tonelen fields are always in milliseconds. Again, needs to be revied by
DAHDI guy.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0015160 DAHDI takes considerably longer than Za...
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-10-07 11:49 mspiceland     Description Updated                          
======================================================================