[asterisk-bugs] [Asterisk 0018070]: [regression] 'D' option of MeetMe does not work for 1st caller (PIN not asked)

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18070 
====================================================================== 
Reported By:                mav3rick
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18070
Category:                   Applications/app_meetme
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           1.6.2.14-rc1 
JIRA:                       SWP-2312 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-09-28 11:42 CDT
Last Modified:              2010-10-04 23:53 CDT
====================================================================== 
Summary:                    [regression] 'D' option of MeetMe does not work for
1st caller (PIN not asked)
Description: 
The D option of MeetMe is not working anymore, at least for the first user.

Example :

exten => s,1,MeetMe(1,1DP,42)

The first user entering the conference is not asked for a PIN (bad) :

    -- Executing [s at CONFERENCE:1] MeetMe("SIP/proxy-00000002", "1,1DP,42")
in new stack
    -- Created MeetMe conference 1023 for conference '1'

While the second user is asked for a PIN (good) :

    -- Executing [s at CONFERENCE:1] MeetMe("SIP/proxy-00000003", "1,1DP,42")
in new stack
    -- <SIP/proxy-00000003> Playing 'conf-getpin.gsm' (language 'en')


Seems like dynamically created conference do not ask the pin to the 1st
user. 
Static conferences configured in meetme.conf are working as expected.

It used to work in previous versions of Asterisk (at least in 1.6.0.X).
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0018006 Meetme unreliable functionality
related to          0017908 [patch] MeetMe PIN handling broken
related to          0015878 [patch] First caller to dynamic confere...
====================================================================== 

---------------------------------------------------------------------- 
 (0127687) kuj (reporter) - 2010-10-04 23:53
 https://issues.asterisk.org/view.php?id=18070#c127687 
---------------------------------------------------------------------- 
When I worked on the patch for 0017908, I deliberately didn't want to touch
dynamic conferences. I don't use them, and I feel the documentation isn't
sufficient. After looking at the code again, I do agree though that the
changes in 0015878 are the likely cause of the symptoms seen by the OP.

However, I'm not sure I have the same expectation for the 'D' option as
the OP. So far, I understood 'D' to mean "prompt the first user for a
conference PIN if no PIN has been set already". But when you invoke
"MeetMe(1,1D,1234)", you've essentially assigned a PIN of 1234, so there's
no need to prompt for a new PIN. But then again, "MeetMe(1,1DP,1234)"
really should prompt for the PIN (because of the 'P' flag). Looking at the
code, it appears the intention was to always prompt for a PIN if either the
'P' flag was specified, or the conference is dynamic (always_prompt=...),
but the check for dynamic conferences and first user (in 0015878) doesn't
account for that.

I think the first thing needed before implementing actual code to address
the OP's observation is to document (and agree on) desired behavior for the
various dynamic options. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-10-04 23:53 kuj            Note Added: 0127687                          
======================================================================