[asterisk-bugs] [Asterisk 0017924]: [patch] Call file errors in Asterisk 1.8beta

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17924 
====================================================================== 
Reported By:                mkeuter
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   17924
Category:                   PBX/pbx_spool
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.8.0-beta4 
JIRA:                       SWP-2149 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.8 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-08-29 07:29 CDT
Last Modified:              2010-10-03 14:15 CDT
====================================================================== 
Summary:                    [patch] Call file errors in Asterisk 1.8beta
Description: 
While testing with 1.8beta, I always get the following errors, when I try
to use a call file:

Aug 28 14:29:28 alix local0.warn asterisk[18174]: WARNING[18213]:
pbx_spool.c:250 in apply_outgoing: At least one of app or extension must be
specified, along with tech and dest in file
/var/spool/asterisk/outgoing/sample.call

Aug 28 14:29:28 alix local0.warn asterisk[18174]: WARNING[18213]:
pbx_spool.c:407 in scan_service: Invalid file contents in
/var/spool/asterisk/outgoing/sample.call, deleting
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0017337 [patch] [regression] flooding /var/spoo...
====================================================================== 

---------------------------------------------------------------------- 
 (0127619) abelbeck (reporter) - 2010-10-03 14:15
 https://issues.asterisk.org/view.php?id=17924#c127619 
---------------------------------------------------------------------- 
I was having the same problem as mkeuter, using a 500MHz embedded
platform.

I have attached a patch that solves this call-file issue for me in my
testing.

Basically, in the inotify_add_watch() call replace the IN_CREATE mask with
IN_CLOSE_WRITE .  On slower machines, the IN_CREATE was caught before the
file was completely written and causing the call-file to fail.  By waiting
for IN_CLOSE_WRITE the file is ready to be processed. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-10-03 14:15 abelbeck       Note Added: 0127619                          
======================================================================