[asterisk-bugs] [Asterisk 0018297]: [patch] MeetMe feature for caching name recordings

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18297 
====================================================================== 
Reported By:                parisioa
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18297
Category:                   Applications/NewFeature
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     confirmed
Asterisk Version:           1.8.0 
JIRA:                       SWP-2583 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-11-12 03:08 CST
Last Modified:              2010-11-24 17:46 CST
====================================================================== 
Summary:                    [patch] MeetMe feature for caching name recordings
Description: 
I was looking for a feature to cache the recording of your name for when
you use options I or i in meetme that announces a users name on entering
and exiting a conference, this way users wouldn’t have to do this every
time.  My goal with this is to auto-join members to a conference without
them having to enter a pin or say their name, yet still have their name
announced to the conference.

Having never created a patch for asterisk I probably didn’t do this
correctly, but in my 1.8 dev server it works great.  I built this against
trunk.

Some of the things I’m not sure about:
1)	I used the voicemail greet file that is saved in
spool/voicemail/default/user/greet
a.	Should it cache a new file and create it in the meetme/ folder instead
of going to the voicemails mailbox to get the greet?
b.	The assumption that the voicemail context is default is probably
incorrect, but I’m not sure how to handle that
c.	If the file doesn’t exist, it will record it and save it in that
location for future use, in sln which doesn’t follow the voicemail.conf
setting for codec types. 
2)	I created the option flag h, just because it was available.  What is
the normal scheme for flag creation?
3)	I added a new field to a struct to keep track of whether or not the
recording was supposed to be saved or not to prevent it from being deleted,
and I’m not sure what the norm is for this either.  I added vmrec to
announce_listitem

Am I wayyyy far off the ball or is this something that can be worked on
and useful enough for others to be committed at some point?  I know I plan
to use it going forward.

====================================================================== 

---------------------------------------------------------------------- 
 (0129123) svnbot (reporter) - 2010-11-24 17:46
 https://issues.asterisk.org/view.php?id=18297#c129123 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 296249

U   trunk/CHANGES
U   trunk/apps/app_meetme.c

------------------------------------------------------------------------
r296249 | citywok | 2010-11-24 17:46:15 -0600 (Wed, 24 Nov 2010) | 11
lines

Meetme use voicemail greet for join/leave announce

Added option v(mailbox@[context]) which tells MeetMe where to look for a
users greet file.  If one does not exist it clears the v option and defers
to the functionality of i/I as/if set by the MeetMe() command.

Review: https://reviewboard.asterisk.org/r/1009/
(closes issue https://issues.asterisk.org/view.php?id=18297)
Reported by: parisioa
Patches:
	meetme_final_patch_v.diff uploaded by parisioa (license 1153)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=296249 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-11-24 17:46 svnbot         Checkin                                      
2010-11-24 17:46 svnbot         Note Added: 0129123                          
======================================================================