[asterisk-bugs] [Asterisk 0018338]: [patch] (Call Completion / SIP) INVITE Fails (Receive a 404 From Asterisk Server) When Using The URI Provided From A NOTIFY(cc-r

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18338 
====================================================================== 
Reported By:                GeorgeKonopacki
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18338
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.8.0 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-11-19 08:40 CST
Last Modified:              2010-11-24 06:58 CST
====================================================================== 
Summary:                    [patch] (Call Completion / SIP) INVITE Fails
(Receive a 404 From Asterisk Server) When Using The URI Provided From A
NOTIFY(cc-r
Description: 
The ‘To’ line in our INVITE contains:

To:
<sip:10f2a43020db0a2c787fa67c6c4d279b at 192.168.233.250:5060;transport=udp>

The function in ‘find_by_notify_uri_helper’ in file chan_sip.c does a
straight strcmp of the ‘To’ with the URI it sent in the NOTIFY
(cc-ready).

This match then fails because we have added ';transport=udp'

return !strcmp(agent_pvt->notify_uri, uri) ? CMP_MATCH | CMP_STOP : 0;

agent_pvt->notify_uri =
sip:10f2a43020db0a2c787fa67c6c4d279b at 192.168.233.250:5060

uri =
sip:10f2a43020db0a2c787fa67c6c4d279b at 192.168.233.250:5060;transport=udp

The Asterisk server is NOT extracting the URI correctly from the ‘To’
line in the INVITE. So strcmp will always fail.
====================================================================== 

---------------------------------------------------------------------- 
 (0129097) GeorgeKonopacki (reporter) - 2010-11-24 06:58
 https://issues.asterisk.org/view.php?id=18338#c129097 
---------------------------------------------------------------------- 
Couldn’t download that patch using wget because our linux box is not
connected to a public network.

I made the code changes by hand (using info in 18338.diff)

sip_uri_cmp works a treat.

Thanks,

George 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-11-24 06:58 GeorgeKonopackiNote Added: 0129097                          
======================================================================