[asterisk-bugs] [Asterisk 0018129]: [patch] Oneway audio from SIP phone to FXS port after FXS port gets a CallWaiting pip

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18129 
====================================================================== 
Reported By:                alecdavis
Assigned To:                rmudgett
====================================================================== 
Project:                    Asterisk
Issue ID:                   18129
Category:                   Channels/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
JIRA:                       SWP-2367 
Regression:                 No 
Reviewboard Link:           https://reviewboard.asterisk.org/r/978/ 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 290865 
Request Review:              
====================================================================== 
Date Submitted:             2010-10-13 04:31 CDT
Last Modified:              2010-11-23 03:28 CST
====================================================================== 
Summary:                    [patch] Oneway audio from SIP phone to FXS port
after FXS port gets a CallWaiting pip
Description: 
Internal SIP phone initiates a call with FXS port on TDM800P.
FXS connected phone has to have FSK CIDCW support to fail, as it will send
back a DTMF 'A' or 'D' when it's ready to receive CallerID.
A normal phone with no CID never fails. 

External call comes in on FXO port, and attempts to ring FXS ports.
Call waiting beep is heard at FXS port, also no outbound audio to SIP
phone.

Then FXS port hook flashes, the FXO port is then connected to FXS as
expected.
But SIP device should hear MOH, but has dead air.

If the FXS port hook flashes to the SIP device, the FXO call then does
hear MOH.
Hook flash again back to FXO call, SIP hears nothing.  
====================================================================== 

---------------------------------------------------------------------- 
 (0129070) alecdavis (manager) - 2010-11-23 03:28
 https://issues.asterisk.org/view.php?id=18129#c129070 
---------------------------------------------------------------------- 
issue_18129_v1.8_v2.tweak.patch

Noticed possible out by 1 sample.
If ever possible, if 1 sample was set for 'cidcwexpire' the
restore_conference isn't in the code path.

now follows/similar to 
 if (p->ringt > 0) {
                if (!(--p->ringt)) { 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-11-23 03:28 alecdavis      Note Added: 0129070                          
======================================================================