[asterisk-bugs] [Asterisk 0018277]: [patch] Use ast_sockaddr_stringify_fmt wrappers for sip show peers

Asterisk Bug Tracker noreply at bugs.digium.com
Thu Nov 18 16:17:07 CST 2010


A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18277 
====================================================================== 
Reported By:                elguero
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18277
Category:                   Channels/chan_sip/General
Reproducibility:            N/A
Severity:                   tweak
Priority:                   normal
Status:                     ready for review
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.8 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-11-08 12:51 CST
Last Modified:              2010-11-18 16:17 CST
====================================================================== 
Summary:                    [patch] Use ast_sockaddr_stringify_fmt wrappers for
sip show peers
Description: 
While trying to track something down in chan_sip and in going through the
latest revisions, I saw the patch for issue
https://issues.asterisk.org/view.php?id=18248 adjusted the display of
_sip_show_peers by using ast_sockaddr_stringify_fmt.  

I have created a patch which uses the wrappers for
ast_sockaddr_stringify_fmt instead of calling the function directly.  The
reason for doing this was to make the code a little bit clearer by
simplifying it.

At the same time, I saw a couple of other places that would benefit from
using the wrappers in netsock2 since it will properly handle IPv4 or IPv6.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0018248 [patch] sippeers command in AMI has inc...
====================================================================== 

---------------------------------------------------------------------- 
 (0128978) elguero (reporter) - 2010-11-18 16:17
 https://issues.asterisk.org/view.php?id=18277#c128978 
---------------------------------------------------------------------- 
No problem... trying to contribute what little bit I can.

One thing I just noticed, please ignore the name of the patch.  I was
working on tracking something down and failed to rename those patches
before uploading. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-11-18 16:17 elguero        Note Added: 0128978                          
======================================================================




More information about the asterisk-bugs mailing list