[asterisk-bugs] [Asterisk 0018310]: hint state changes deadlock/race

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18310 
====================================================================== 
Reported By:                one47
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18310
Category:                   Core/PBX
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.2.14 
JIRA:                       SWP-2541 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-11-15 12:19 CST
Last Modified:              2010-11-16 08:32 CST
====================================================================== 
Summary:                    hint state changes deadlock/race
Description: 
VERY similar to https://issues.asterisk.org/view.php?id=18165, but this is a
different deadlock path, so I have
raised a separate report.

Thread 1: taskprocessor  -> handle_statechange
    Lock order = conlock, hints, hint, pvt
Thread 2: chan_sip.c:  handle_request_do -> handle_response_notify
    Lock order = pvt, conlock

Thread2 only gets into the conlock if STATECHANGEQUEUE is true, ie. there
are rapid state changes happening on a subscribed hint.
====================================================================== 

---------------------------------------------------------------------- 
 (0128894) schmidts (manager) - 2010-11-16 08:32
 https://issues.asterisk.org/view.php?id=18310#c128894 
---------------------------------------------------------------------- 
you are right for the patch ;)

ast_get_hint or in detail ast_hint_extension is another possible lock
place but we could change this to use the hint container here too. there is
IMO no need for the conlock anymore cause we could use the refcounter value
of hints for this.

i will try to write a patch for this.

best regards

stefan 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-11-16 08:32 schmidts       Note Added: 0128894                          
======================================================================