[asterisk-bugs] [Asterisk 0018075]: [patch] Asterisk fails to recognize SUBSCRIBE retransmissions and tries to re-authenticate them, which breaks presence on polyco

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18075 
====================================================================== 
Reported By:                mdu113
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18075
Category:                   Channels/chan_sip/Subscriptions
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           SVN 
JIRA:                       SWP-2327 
Regression:                 No 
Reviewboard Link:           https://reviewboard.asterisk.org/r/1005/ 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 289177 
Request Review:              
====================================================================== 
Date Submitted:             2010-09-29 16:16 CDT
Last Modified:              2010-11-10 01:42 CST
====================================================================== 
Summary:                    [patch] Asterisk fails to recognize SUBSCRIBE
retransmissions and tries to re-authenticate them, which breaks presence on
polyco
Description: 
Here's what happens from asterisk point of view:
-> SUBSCRIBE
<- 401 Unauthorized
-> SUBSCRIBE with auth
<- 200 OK (lost)
<- NOTIFY
-> 200 OK for NOTIFY
-> SUBSCRIBE with auth retransmission
<- 401 Unauthorized
At this point polycom phone received 2 "401 Unauthorized" in a row and it
completely gives up on resubscribing to this hint until reboot. While
polycom behavior is questionable, I believe asterisk should recognize
retransmission and resubmit 200OK in this case
====================================================================== 

---------------------------------------------------------------------- 
 (0128736) ramonpeek (reporter) - 2010-11-10 01:42
 https://issues.asterisk.org/view.php?id=18075#c128736 
---------------------------------------------------------------------- 
Question: 
Did the retransmission indeed occur before the "T2 Timer" (4s.) expired?
(Because the attached logs don't show the time)

Assuming it did...
Then its important to know that I've seen this exact behavior occur on
REGISTER requests in Asterisk 1.4.37. So I guess we need to fix this for
not only SUBSCRIBES but other transactions too. And I would think this
should be fixed in a more general location within the source code.
Also interesting to read is this review:
https://reviewboard.asterisk.org/r/687/ 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-11-10 01:42 ramonpeek      Note Added: 0128736                          
======================================================================