[asterisk-bugs] [Asterisk 0018272]: [patch] distributed device state does not work

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18272 
====================================================================== 
Reported By:                klaus3000
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   18272
Category:                   Resources/res_jabber
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Asterisk Version:           1.8.0 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-11-07 14:00 CST
Last Modified:              2010-11-08 14:58 CST
====================================================================== 
Summary:                    [patch] distributed device state does not work
Description: 
from res_jabber.c:

/*! \brief Global flags, initialized to default values */
static struct ast_flags globalflags = { AJI_AUTOREGISTER | AJI_AUTOACCEPT
};

/*! \brief PubSub flags, initialized to default values */
static struct ast_flags pubsubflags = { AJI_AUTOREGISTER };


As you see, pubsubflags is initialized to AJI_AUTOREGISTER - but
AJI_AUTOREGISTER is meant for global flags.


from jabber.h:

enum {
        AJI_AUTOPRUNE = (1 << 0),
        AJI_AUTOREGISTER = (1 << 1),
        AJI_AUTOACCEPT = (1 << 2),
};

enum {
        AJI_XEP0248 = (1 << 0),
        AJI_PUBSUB = (1 << 1),
        AJI_PUBSUB_AUTOCREATE = (1 << 2),
};

As you see AJI_AUTOREGISTER==AJI_PUBSUB. Thus, res_jabber always thinks
that there is already a connection with pubsub enabled and thus does not
allow any other connection to enable pubsub.
====================================================================== 

---------------------------------------------------------------------- 
 (0128708) Marquis (reporter) - 2010-11-08 14:58
 https://issues.asterisk.org/view.php?id=18272#c128708 
---------------------------------------------------------------------- 
You are exactly correct.  This is really my fault for not committing this
before it was merged.  It's in my backport to 1.6.2 that I'm running in
production, so I don't know why it wasn't already there.

The CLI cleanups look sound, too, though I haven't tried them at all. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-11-08 14:58 Marquis        Note Added: 0128708                          
======================================================================