[asterisk-bugs] [Asterisk 0018189]: RFC2833 DTMF generation broken due to SSRC change on bridges channels

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=18189 
====================================================================== 
Reported By:                marcbou
Assigned To:                twilson
====================================================================== 
Project:                    Asterisk
Issue ID:                   18189
Category:                   Core/RTP
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.8.0 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-10-22 12:13 CDT
Last Modified:              2010-11-01 10:33 CDT
====================================================================== 
Summary:                    RFC2833 DTMF generation broken due to SSRC change on
bridges channels
Description: 
Since upgrading to the latest 1.8.0-rc, DTMF digits sent over SIP/RTP to
our service provider were no longer being detected.

We analyzed packet dumps, comparing old and new RTP packets being
generated by asterisk.

The difference was tracked down to asterisk 1.8.0-rc now changing the SSRC
value for RFC2833 DTMF digit packets.

If in main/channel.c:ast_channel_bridge() I comment out 

    ast_indicate(c0, AST_CONTROL_SRCCHANGE);
    ast_indicate(c1, AST_CONTROL_SRCCHANGE);

the SSRC no longer changes for DTMF digits and the provider can detect
them again.

However I am not sure if the change doesn't adversely affect other things.
Please advise.

Kind regards,

Marc Boucher



====================================================================== 

---------------------------------------------------------------------- 
 (0128497) twilson (administrator) - 2010-11-01 10:33
 https://issues.asterisk.org/view.php?id=18189#c128497 
---------------------------------------------------------------------- 
The ssrc change was put in to fix issue 17404 and causes this regression.
I'll look at finding a way to fix 17404 that doesn't re-break this issue
(as it has been fixed a couple of times now) and put in some comments to
make sure it doesn't happen again. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-11-01 10:33 twilson        Note Added: 0128497                          
======================================================================