[asterisk-bugs] [Asterisk 0017378]: StopMixMonitor crashes at the end of the recording, when initiated by the callee.

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17378 
====================================================================== 
Reported By:                rommelraj
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17378
Category:                   Applications/app_mixmonitor
Reproducibility:            always
Severity:                   crash
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           1.6.2.7 
JIRA:                       SWP-1523 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-05-23 05:55 CDT
Last Modified:              2010-05-29 05:38 CDT
====================================================================== 
Summary:                    StopMixMonitor crashes at the end of the recording,
when initiated by the callee.
Description: 
StopMixMonitor crashes at the end of the recording with a core dump.
This seems to only happen when the callee initiates the recording.
I have tried this many times and it always crashes.
I think it worked with version 1.6.1.1. But not with 1.6.2.6 or 1.6.2.7.
 
====================================================================== 

---------------------------------------------------------------------- 
 (0122643) rommelraj (reporter) - 2010-05-29 05:38
 https://issues.asterisk.org/view.php?id=17378#c122643 
---------------------------------------------------------------------- 
Prossible fix:
I traced the bug with DDD and added the following lines in channel.c and
frame.c to fix the issue. I am not sure why the array has the 0xf value. I
did not try to figure out how it got placed in the array.

In channel.c: 3546
      for (cur = f; cur; cur = AST_LIST_NEXT(cur, frame_list)) {
            if (cur == (struct ast_frame *)0xf) {   /* RRR - 05/28/2010
*/
                    break;                          /* RRR - 05/28/2010
*/
            }
            new_frame = ast_audiohook_write_list(chan, chan->audiohooks,
AST_AUDIOHOOK_DIRECTION_WRITE, cur);

In frame.c: 396
        if (fr == NULL) {                   /* RRR 05/28/2010 */
            return (struct ast_frame *)0xf; /* RRR 05/28/2010 */
        }


This fix/patch seems to make it work ok. Not sure if it is the right way
to do this. But it works for me.
I have a 250 phone installation at my insurance company and I needed to
get the call recording working asap. So far Asterisk has been doing fine at
our company. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-05-29 05:38 rommelraj      Note Added: 0122643                          
======================================================================