[asterisk-bugs] [Asterisk 0014331]: [patch] reg->username is parsed for each registration refresh rather than once on sip reload

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14331 
====================================================================== 
Reported By:                Nick_Lewis
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   14331
Category:                   Channels/chan_sip/Registration
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.6.1-beta4 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-01-26 06:19 CST
Last Modified:              2010-05-26 14:46 CDT
====================================================================== 
Summary:                    [patch] reg->username is parsed for each
registration refresh rather than once on sip reload
Description: 
The registration string can contain an expanded user portion of the form
user at domain (and possibly user at domain:domainport). This expanded user
portion is currently stored in reg->username and parsed each time there is
a registration refresh. It would be better if the configuration was parsed
only once and the sip_registry structure contained the atomic fields
separately through the addition of, for example, reg->regdomain and
reg->regdomainport elements
====================================================================== 

---------------------------------------------------------------------- 
 (0122518) svnbot (reporter) - 2010-05-26 14:46
 https://issues.asterisk.org/view.php?id=14331#c122518 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 266090

U   trunk/channels/chan_sip.c
U   trunk/channels/sip/config_parser.c
U   trunk/channels/sip/include/sip.h
U   trunk/main/app.c

------------------------------------------------------------------------
r266090 | dvossel | 2010-05-26 14:46:49 -0500 (Wed, 26 May 2010) | 20
lines

do all sip registry parsing before transmit_register

This patch breaks up every part of the sip registry string during
config parsing and removes all parsing from transmit_register().
Thanks to Nick_Lewis for contributing this patch!

(closes issue https://issues.asterisk.org/view.php?id=14331)
Reported by: Nick_Lewis
Patches:
      chan_sip.c-domparse.patch uploaded by Nick Lewis (license 657)
      chan_sip.c.patch uploaded by Nick Lewis (license 657)
      chan_sip.c.domainparse3.patch uploaded by Nick Lewis (license 657)
      chan_sip.c-domparse4.patch uploaded by Nick Lewis (license 657)
      chan_sip.c-domparse5.patch uploaded by Nick Lewis (license 657)
      nicklewispatch.diff uploaded by dvossel (license 671)
Tested by: Nick_Lewis, dvossel

Review: https://reviewboard.asterisk.org/r/628/


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=266090 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-05-26 14:46 svnbot         Checkin                                      
2010-05-26 14:46 svnbot         Note Added: 0122518                          
======================================================================