[asterisk-bugs] [Asterisk 0017334]: [patch] [regression] CDRs being written where they were not before after revision 258670

Tue May 25 12:00:11 CDT 2010

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17334 
====================================================================== 
Reported By:                jvandal
Assigned To:                mnicholson
====================================================================== 
Project:                    Asterisk
Issue ID:                   17334
Category:                   CDR/General
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     closed
Target Version:             1.4.32
Asterisk Version:           1.4.32-rc1 
JIRA:                       SWP-1458 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 262898 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-05-13 11:26 CDT
Last Modified:              2010-05-25 12:00 CDT
====================================================================== 
Summary:                    [patch] [regression] CDRs being written where they
were not before after revision 258670
Description: 
The following changes on 1.4 SVN cause lots of problems ...

By sample, I dial a Queue (ACD) and hangup ... I have an ABANDON event on
Queue Log but no CDR records.

If I enable 'unanswered=yes' on cdr.conf, now I have CDR ...

------------------------------------------------------------------------
r258670 | mnicholson | 2010-04-22 17:49:07 -0400 (Thu, 22 Apr 2010) | 11
lines

Fix broken CDR behavior.

This change allows a CDR record previously marked with disposition
ANSWERED to be set as BUSY or NO ANSWER.

Additionally this change partially reverts r235635 and does not set the
AST_CDR_FLAG_ORIGINATED flag on CDRs
generated from ast_call().  To preserve proper CDR behavior, the
AST_CDR_FLAG_DIALED flag is now cleared from
all brige CDRs in ast_bridge_call().

(closes issue https://issues.asterisk.org/view.php?id=16797)
Reported by: VarnishedOtter
Tested by: mnicholson

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0016797 Originating a call from within the dial...
related to          0017396 When caller exits due to EXITEMPTY in a...
====================================================================== 

---------------------------------------------------------------------- 
 (0122405) svnbot (reporter) - 2010-05-25 12:00
 https://issues.asterisk.org/view.php?id=17334#c122405 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 265611

_U  trunk/
U   trunk/apps/app_queue.c

------------------------------------------------------------------------
r265611 | mnicholson | 2010-05-25 12:00:10 -0500 (Tue, 25 May 2010) | 15
lines

Merged revisions 265610 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r265610 | mnicholson | 2010-05-25 11:48:19 -0500 (Tue, 25 May 2010) | 8
lines

  Don't mark the cdr records of unanswered queue calls with "NOANSWER". 
This restores the behavior prior to r258670.

  (closes issue https://issues.asterisk.org/view.php?id=17334)
  Reported by: jvandal
  Patches:
        queue-cdr-fixes1.diff uploaded by mnicholson (license 96)
  Tested by: aragon, jvandal
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=265611 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-05-25 12:00 svnbot         Checkin                                      
2010-05-25 12:00 svnbot         Note Added: 0122405                          
======================================================================