[asterisk-bugs] [Asterisk 0017393]: [patch] AGISTATUS bug in Asterisk 1.6.2.7

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17393 
====================================================================== 
Reported By:                siby
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17393
Category:                   Applications/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.2.7 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-05-25 05:18 CDT
Last Modified:              2010-05-25 11:22 CDT
====================================================================== 
Summary:                    [patch] AGISTATUS bug in Asterisk 1.6.2.7
Description: 
I was just verifying different states of AGISTATUS variable i.e
SUCCESS,FAILURE,NOTFOUND and HANGUP.

I have noticed a what looks like a bug in the behaviour for teh case
HANGUP.

In this test case, I am trying to hang up the call (from caller side)
while it is still executing the AGI script.

When i do this i recive an AGISTATUS of FAILURE when I was expecting
HANGUP, as per the 'show application' explination.

 
Here is a simple setup to replicate the issue, 

extensions.conf

[test]
exten => _X.,1,Answer()
exten => _X.,n,AGI(agi-test.php)
exten => _X.,n,NoOp(AGISTATUS: ${AGISTATUS})
exten => _X.,n,Hangup()
exten => h,1,NoOp(AGISTATUS: ${AGISTATUS})

agi-test.php

#!/usr/bin/php
<?php
sleep(7);
?>

Any help/advice would be very much appreciated.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
duplicate of        0017385 AGISTATUS bug in Asterisk 1.6.1.8
====================================================================== 

---------------------------------------------------------------------- 
 (0122398) Delvar (reporter) - 2010-05-25 11:22
 https://issues.asterisk.org/view.php?id=17393#c122398 
---------------------------------------------------------------------- 
iv attached a quick patch that seem to fix the issue of resetting AGISTATUS
after hangup, the cause seems to be the line,
if (returnstatus) {
 returnstatus = -1;
}

some sort of hack to set FAIL if not success...
surly a better option would be to default to FAIL (-1) and only change it
when it needs to ie on hangup. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-05-25 11:22 Delvar         Note Added: 0122398                          
======================================================================