[asterisk-bugs] [Asterisk 0017334]: [regression] CDRs being written where they were not before after revision 258670

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17334 
====================================================================== 
Reported By:                jvandal
Assigned To:                mnicholson
====================================================================== 
Project:                    Asterisk
Issue ID:                   17334
Category:                   CDR/General
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     feedback
Target Version:             1.4.32
Asterisk Version:           1.4.32-rc1 
JIRA:                       SWP-1458 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 262898 
Request Review:              
====================================================================== 
Date Submitted:             2010-05-13 11:26 CDT
Last Modified:              2010-05-20 10:27 CDT
====================================================================== 
Summary:                    [regression] CDRs being written where they were not
before after revision 258670
Description: 
The following changes on 1.4 SVN cause lots of problems ...

By sample, I dial a Queue (ACD) and hangup ... I have an ABANDON event on
Queue Log but no CDR records.

If I enable 'unanswered=yes' on cdr.conf, now I have CDR ...

------------------------------------------------------------------------
r258670 | mnicholson | 2010-04-22 17:49:07 -0400 (Thu, 22 Apr 2010) | 11
lines

Fix broken CDR behavior.

This change allows a CDR record previously marked with disposition
ANSWERED to be set as BUSY or NO ANSWER.

Additionally this change partially reverts r235635 and does not set the
AST_CDR_FLAG_ORIGINATED flag on CDRs
generated from ast_call().  To preserve proper CDR behavior, the
AST_CDR_FLAG_DIALED flag is now cleared from
all brige CDRs in ast_bridge_call().

(closes issue https://issues.asterisk.org/view.php?id=16797)
Reported by: VarnishedOtter
Tested by: mnicholson


======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0016797 Originating a call from within the dial...
====================================================================== 

---------------------------------------------------------------------- 
 (0122210) aragon (reporter) - 2010-05-20 10:27
 https://issues.asterisk.org/view.php?id=17334#c122210 
---------------------------------------------------------------------- 
I ran several tests.
Tested each scenario identically in r258670 with cdr.conf unanswered=yes
and with #unanswered=yes
For each scenario a test file with cli,
/var/log/asterisk/cdr-custom/MASTER.csv, and queue_log results will be
uploaded.
Scenarios:
ANSWERED
ABANDON
EXITUNAVAIL
EXITEMPTY
EXITFULL
EXITWITHKEY
EXITWITHTIMEOUT

I ran the exact same scenarios with r258670 reverted with same logs
attached.

During my tests I also discovered a separate issue.
There were no agents logged during EXITEMPTY tests yet any call that does
EXITEMPTY does not write EXITEMPTY to queue_log.  EXITUNAVAIL is written
instead.  I'll probably open a separate bug report for this issue.  But the
results are logged to this ticket regardless since they are part of my
tests. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-05-20 10:27 aragon         Note Added: 0122210                          
======================================================================