[asterisk-bugs] [Asterisk 0017235]: [patch] asterisk dsp always reports detected DTMF length to be 0ms

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17235 
====================================================================== 
Reported By:                frawd
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   17235
Category:                   Core/General
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     ready for testing
Target Version:             1.6.2.9
Asterisk Version:           1.6.2.7-rc2 
JIRA:                       SWP-1337 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-04-23 10:21 CDT
Last Modified:              2010-05-19 04:41 CDT
====================================================================== 
Summary:                    [patch] asterisk dsp always reports detected DTMF
length to be 0ms
Description: 
The attached patch makes the DSP report the correct length for DTMF
detected in the audio.

Tested with DAHDI channels (FXS, FXO, ISDN PRI) and SIP channels
configured as "inband".
====================================================================== 

---------------------------------------------------------------------- 
 (0122125) frawd (reporter) - 2010-05-19 04:41
 https://issues.asterisk.org/view.php?id=17235#c122125 
---------------------------------------------------------------------- 
Looks good, you could also add "dtmf.hits * DTMF_GSIZE" to the counter
whenever there is a miss (and only on the first one), but I don't think
incrementing a counter on each hit affects performance and your way is much
more understandable when reading the code.

Last thing, I believe "event_len" should be initialized to '0' for the
DTMF_BEGIN frame to have a '0' length (I'm not sure it matters). 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-05-19 04:41 frawd          Note Added: 0122125                          
======================================================================