[asterisk-bugs] [Asterisk 0016749]: [patch] DSP progress detection unable to detect SIT

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16749 
====================================================================== 
Reported By:                dant
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   16749
Category:                   Core/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Target Version:             1.6.2.9
Asterisk Version:           SVN 
JIRA:                       SWP-837 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-02-02 00:34 CST
Last Modified:              2010-05-19 01:41 CDT
====================================================================== 
Summary:                    [patch] DSP progress detection unable to detect SIT
Description: 
The DSP should be able to detect the SIT. The existing code checks for the
first tone followed by the second tone, followed by the third tone in
sequence and on detection of the third tone allows firing a CONGESTION
control frame.

This unfortunately doesn't work due to the fact that entire SIT is about 1
second long, the DSP is working with smaller samples and the code will not
stay in a second or third tone state beyond one pass.

This issue is being raised against trunk, but, the problem appears to be
present even in 1.2.
====================================================================== 

---------------------------------------------------------------------- 
 (0122115) svnbot (reporter) - 2010-05-19 01:41
 https://issues.asterisk.org/view.php?id=16749#c122115 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 263950

_U  trunk/
U   trunk/main/dsp.c

------------------------------------------------------------------------
r263950 | tilghman | 2010-05-19 01:41:04 -0500 (Wed, 19 May 2010) | 15
lines

Merged revisions 263949 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r263949 | tilghman | 2010-05-19 01:32:27 -0500 (Wed, 19 May 2010) | 8
lines
  
  Because progress is called multiple times, across several frames, we
must persist states when detecting multitone sequences.
  
  (closes issue https://issues.asterisk.org/view.php?id=16749)
   Reported by: dant
   Patches: 
         dsp.c-bug16749-1.patch uploaded by dant (license 670)
   Tested by: dant
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=263950 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-05-19 01:41 svnbot         Checkin                                      
2010-05-19 01:41 svnbot         Note Added: 0122115                          
======================================================================