[asterisk-bugs] [Asterisk 0017276]: bypass "contactdeny" with nat=yes

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17276 
====================================================================== 
Reported By:                klaus3000
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17276
Category:                   Channels/chan_sip/Registration
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           SVN 
JIRA:                       SWP-1462 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-05-03 09:56 CDT
Last Modified:              2010-05-17 12:59 CDT
====================================================================== 
Summary:                    bypass "contactdeny" with nat=yes
Description: 
Hi!

chan_sip's "contactdeny" feature screens the "to be registered contact".
In case of nat=yes it should not use the address information from the
Contact header (which is not used at all for routing), but the source IP
address of the request.

Thus, if nat=yes and a client sends a request from a denied IP address
(e.g. by spoofing the src-IP address) it can bypass the screening.
====================================================================== 

---------------------------------------------------------------------- 
 (0122007) klaus3000 (reporter) - 2010-05-17 12:59
 https://issues.asterisk.org/view.php?id=17276#c122007 
---------------------------------------------------------------------- 
There wasn't any feedback to my proposal at:
http://lists.digium.com/pipermail/asterisk-dev/2010-May/044065.html

Thus, I write a patch which fits above proposal. Testresults (IMO OK) are
attached too. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-05-17 12:59 klaus3000      Note Added: 0122007                          
======================================================================