[asterisk-bugs] [Asterisk 0017231]: [patch] Manager cookies isn't compatible with rfc2109

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17231 
====================================================================== 
Reported By:                ecarruda
Assigned To:                lmadsen
====================================================================== 
Project:                    Asterisk
Issue ID:                   17231
Category:                   Core/ManagerInterface
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Target Version:             1.6.2.9
Asterisk Version:           SVN 
JIRA:                       SWP-1332 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-04-22 13:44 CDT
Last Modified:              2010-05-17 09:37 CDT
====================================================================== 
Summary:                    [patch] Manager cookies isn't compatible with
rfc2109
Description: 
Manager on all asterisk versions isn't compatible with rfc2109, some http
clients return error when try to use cookies with AJAM.

The problem is the version paramter,

Manager Return:

Version: "1"

RFC defines:

Version:1

I'm sending the patch based on trunk, to asterisk 1.4.30 and 1.6.2.6

====================================================================== 

---------------------------------------------------------------------- 
 (0121973) svnbot (reporter) - 2010-05-17 09:37
 https://issues.asterisk.org/view.php?id=17231#c121973 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 263457

_U  trunk/
U   trunk/main/manager.c

------------------------------------------------------------------------
r263457 | lmadsen | 2010-05-17 09:37:35 -0500 (Mon, 17 May 2010) | 19
lines

Recorded merge of revisions 263456 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r263456 | lmadsen | 2010-05-17 09:35:18 -0500 (Mon, 17 May 2010) | 11
lines
  
  Manager cookies are not compatible with RFC2109.
  
  The Version field in the cookies we're setting contain quotes around the
version
  number which is not compatible with RFC2109 and breaks some
implementations.
  
  (closes issue https://issues.asterisk.org/view.php?id=17231)
  Reported by: ecarruda
  Patches:
        manager_rfc2109-trunk-v1.patch uploaded by ecarruda (license 559)
        manager_rfc2109-1.6.2-v1.patch uploaded by ecarruda (license 559)
  Tested by: ecarruda, russell
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=263457 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-05-17 09:37 svnbot         Checkin                                      
2010-05-17 09:37 svnbot         Note Added: 0121973                          
======================================================================