[asterisk-bugs] [Asterisk 0017156]: [patch] Command/Response queue stuck

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17156 
====================================================================== 
Reported By:                dveiga
Assigned To:                mnicholson
====================================================================== 
Project:                    Asterisk
Issue ID:                   17156
Category:                   Addons/chan_mobile
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.2 
SVN Revision (number only!): 1097 
Request Review:              
====================================================================== 
Date Submitted:             2010-04-08 19:25 CDT
Last Modified:              2010-05-11 23:37 CDT
====================================================================== 
Summary:                    [patch] Command/Response queue stuck
Description: 
My phone, a Samsung GT-S5230, seems to send \r\n after the responses. The
\r is interpreted as the terminator and the \n ends up as the first char of
the next response. at_read_full() fails under theese circumstances
returning AT_UNKNOWN. A copy of the debug info is appended in "additional
information".
The proposed patch trims the answer prior to processing, solving the
problem.
====================================================================== 

---------------------------------------------------------------------- 
 (0121764) dveiga (reporter) - 2010-05-11 23:37
 https://issues.asterisk.org/view.php?id=17156#c121764 
---------------------------------------------------------------------- 
First of all I want to correct what I said before. It is not that the phone
sends \r\n and the \n ends up as the first char of the next command. The
problem is the phone seds \r\n\r\n, and the second \r\n ends up as an empty
command that causes the error explained before.
Anyhow, now that I've understood the code a little bit better, I changed
the patch. The previous one discards the empty command before processing
it. I didn't like it because it appears in the debug info as an unknown
command. This new patch discards the empty line from the beggining, and
nothing appears in the debug info. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-05-11 23:37 dveiga         Note Added: 0121764                          
======================================================================