[asterisk-bugs] [Asterisk 0017235]: [patch] asterisk dsp always reports detected DTMF length to be 0ms

[Asterisk Bug Tracker]

The following issue is now READY FOR TESTING. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17235 
====================================================================== 
Reported By:                frawd
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   17235
Category:                   Core/General
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     ready for testing
Target Version:             1.6.2.9
Asterisk Version:           1.6.2.7-rc2 
JIRA:                       SWP-1337 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-04-23 10:21 CDT
Last Modified:              2010-05-11 17:54 CDT
====================================================================== 
Summary:                    [patch] asterisk dsp always reports detected DTMF
length to be 0ms
Description: 
The attached patch makes the DSP report the correct length for DTMF
detected in the audio.

Tested with DAHDI channels (FXS, FXO, ISDN PRI) and SIP channels
configured as "inband".
====================================================================== 

---------------------------------------------------------------------- 
 (0121756) tilghman (administrator) - 2010-05-11 17:54
 https://issues.asterisk.org/view.php?id=17235#c121756 
---------------------------------------------------------------------- 
I made some slight modifications to your patch, because it was still
possible for 0-length DTMF_END frames to be sent out, due to the
possibility of hits_to_begin being lower than misses_to_end.  If the new
digit was detected at the end of a frame, but the old digit's misses were
not sufficiently high enough to declare an end, then you could get a
zero-length DTMF_END.  I consider that possibility a long shot, but it's
worth avoiding, anyway. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-05-11 17:54 tilghman       Note Added: 0121756                          
2010-05-11 17:54 tilghman       Status                   confirmed => ready for
testing
======================================================================