[asterisk-bugs] [Asterisk 0016696]: [patch] Solaris sed fails on generating ael_lex.c

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16696 
====================================================================== 
Reported By:                bklang
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   16696
Category:                   Core/Portability
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Target Version:             1.6.2.9
Asterisk Version:           SVN 
JIRA:                       SWP-801 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.2 
SVN Revision (number only!): 242811 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-01-25 11:17 CST
Last Modified:              2010-05-11 14:57 CDT
====================================================================== 
Summary:                    [patch] Solaris sed fails on generating ael_lex.c
Description: 
I noticed a problem when doing a "make install" after building Asterisk
from source on OpenSolaris:


  [LD] aelparse.o aelbison.o pbx_ael.o hashtab.o ael_main.o ast_expr2f.o
ast_expr2.o strcompat.o pval.o extconf.o -> aelparse
Undefined                       first referenced
 symbol                             in file
ael_yylex                           aelbison.o
reset_argcount                      aelbison.o
my_file                             aelbison.o
ael2_parse                          pbx_ael.o
reset_parencount                    aelbison.o
reset_semicount                     aelbison.o
prev_word                           aelbison.o
ld: fatal: symbol referencing errors. No output written to aelparse
collect2: ld returned 1 exit status
gmake[1]: *** [aelparse] Error 1
gmake: *** [utils] Error 2


Scrolling up through the build log I see the following line:
   [FLEX] ael/ael.flex -> ael/ael_lex.c
sed: command garbled: /begin standard C headers/i#include "asterisk.h"
   [BISON] ael/ael.y -> ael/ael.tab.c


I suspect this is due to a difference between GNU sed and Solaris'
provided sed, but I'm not sure.

====================================================================== 

---------------------------------------------------------------------- 
 (0121740) svnbot (reporter) - 2010-05-11 14:57
 https://issues.asterisk.org/view.php?id=16696#c121740 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 262423

_U  branches/1.6.0/
U   branches/1.6.0/res/Makefile

------------------------------------------------------------------------
r262423 | qwell | 2010-05-11 14:57:56 -0500 (Tue, 11 May 2010) | 25 lines

Merged revisions 262422 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r262422 | qwell | 2010-05-11 14:57:24 -0500 (Tue, 11 May 2010) | 18
lines
  
  Merged revisions 262421 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r262421 | qwell | 2010-05-11 14:55:42 -0500 (Tue, 11 May 2010) | 11
lines
    
    Use a less silly method for modifying a flex-generated file.
    
    The sed syntax that was used wasn't actually valid, causing some
versions to
    choke.  This is the method that is used in 1.6.x+ for similar changes.
    
    (closes issue https://issues.asterisk.org/view.php?id=16696)
    Reported by: bklang
    Patches: 
          16696-sedfix.diff uploaded by qwell (license 4)
    Tested by: qwell
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=262423 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-05-11 14:57 svnbot         Checkin                                      
2010-05-11 14:57 svnbot         Note Added: 0121740                          
======================================================================