[asterisk-bugs] [Asterisk 0017302]: [patch] Eliminate compiler warning in app_voicemail.c

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17302 
====================================================================== 
Reported By:                jcovert
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   17302
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.6.2.7 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2010-05-06 14:27 CDT
Last Modified:              2010-05-11 12:25 CDT
====================================================================== 
Summary:                    [patch] Eliminate compiler warning in
app_voicemail.c
Description: 
There's a harmless but incorrect bit of code in app_voicemail which
produces the following compiler warning with the default compiler options
on Darwin:

app_voicemail.c: In function 'vm_execmain':
app_voicemail.c:9346: warning: control may reach end of non-void function
'vm_intro' being inlined

It is strongly recommended C coding practice to ensure that the final
statement in any non-void function is a return with a value.  While the
code here as currently written would always execute a return with a value,
it would be better quality and less likely to grow ugly scales due to a
future change if it were corrected as indicated in the attached patch.

The patch is relative to trunk.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0017297 [patch] [regression] 1.6.2.7 hangs duri...
====================================================================== 

---------------------------------------------------------------------- 
 (0121722) svnbot (reporter) - 2010-05-11 12:25
 https://issues.asterisk.org/view.php?id=17302#c121722 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 262340

_U  branches/1.6.2/
U   branches/1.6.2/Makefile.rules
U   branches/1.6.2/apps/app_voicemail.c

------------------------------------------------------------------------
r262340 | tilghman | 2010-05-11 12:25:28 -0500 (Tue, 11 May 2010) | 16
lines

Merged revisions 262330 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r262330 | tilghman | 2010-05-11 12:23:51 -0500 (Tue, 11 May 2010) | 9
lines
  
  Merged revisions 262321 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r262321 | tilghman | 2010-05-11 12:22:07 -0500 (Tue, 11 May 2010) | 2
lines
    
    Fix issue https://issues.asterisk.org/view.php?id=17302 a slightly different
way (mad props to Qwell)
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=262340 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-05-11 12:25 svnbot         Checkin                                      
2010-05-11 12:25 svnbot         Note Added: 0121722                          
======================================================================