[asterisk-bugs] [Asterisk 0017302]: [patch] Eliminate compiler warning in app_voicemail.c

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17302 
====================================================================== 
Reported By:                jcovert
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17302
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.6.2.7 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-05-06 14:27 CDT
Last Modified:              2010-05-06 18:56 CDT
====================================================================== 
Summary:                    [patch] Eliminate compiler warning in
app_voicemail.c
Description: 
There's a harmless but incorrect bit of code in app_voicemail which
produces the following compiler warning with the default compiler options
on Darwin:

app_voicemail.c: In function 'vm_execmain':
app_voicemail.c:9346: warning: control may reach end of non-void function
'vm_intro' being inlined

It is strongly recommended C coding practice to ensure that the final
statement in any non-void function is a return with a value.  While the
code here as currently written would always execute a return with a value,
it would be better quality and less likely to grow ugly scales due to a
future change if it were corrected as indicated in the attached patch.

The patch is relative to trunk.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0017297 [patch] [regression] 1.6.2.7 hangs duri...
====================================================================== 

---------------------------------------------------------------------- 
 (0121525) tilghman (administrator) - 2010-05-06 18:56
 https://issues.asterisk.org/view.php?id=17302#c121525 
---------------------------------------------------------------------- 
1) In fact, it was agreed that it was a compiler bug, and it was fixed. 
The remark about "false positives" was a question about whether it would be
fixed in gcc 4.0; since it was a diagnostic error, only, and because the
change was invasive, the maintainers elected against it.
2) The code is completely maintainable, as is, and it was intentionally
coded that way to make it more maintainable.
3) Please cite the relevant style guide where a conditional cannot be the
final construct in a non-void function.
4) You are incorrect.  I referenced the correct patch in the previous
reply. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-05-06 18:56 tilghman       Note Added: 0121525                          
======================================================================