[asterisk-bugs] [Asterisk 0017302]: [patch] Eliminate compiler warning in app_voicemail.c

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17302 
====================================================================== 
Reported By:                jcovert
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17302
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.6.2.7 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-05-06 14:27 CDT
Last Modified:              2010-05-06 16:46 CDT
====================================================================== 
Summary:                    [patch] Eliminate compiler warning in
app_voicemail.c
Description: 
There's a harmless but incorrect bit of code in app_voicemail which
produces the following compiler warning with the default compiler options
on Darwin:

app_voicemail.c: In function 'vm_execmain':
app_voicemail.c:9346: warning: control may reach end of non-void function
'vm_intro' being inlined

It is strongly recommended C coding practice to ensure that the final
statement in any non-void function is a return with a value.  While the
code here as currently written would always execute a return with a value,
it would be better quality and less likely to grow ugly scales due to a
future change if it were corrected as indicated in the attached patch.

The patch is relative to trunk.
====================================================================== 

---------------------------------------------------------------------- 
 (0121516) jcovert (reporter) - 2010-05-06 16:46
 https://issues.asterisk.org/view.php?id=17302#c121516 
---------------------------------------------------------------------- 
If you read the comments at
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19699 it's not clear that the
statement in 21191 that this is "not bad style" is valid.

Note the issue of "false positives" vs "false negatives".

The code would be much more robust, especially since the statements above
my proposed fix are subject to constant revision, if you apply my patch. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-05-06 16:46 jcovert        Note Added: 0121516                          
======================================================================