[asterisk-bugs] [Asterisk 0017243]: [regression] attended transfered calls appearance in the queue_log

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17243 
====================================================================== 
Reported By:                Rami
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17243
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           1.4.30 
JIRA:                       SWP-1339 
Regression:                 Yes 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-04-26 05:44 CDT
Last Modified:              2010-05-04 02:39 CDT
====================================================================== 
Summary:                    [regression] attended transfered calls appearance in
the queue_log
Description: 
Hello,
When Agent receives a call from a queue and want to transfer it using
attended transfer the line which is written to the queue_log is incorrect, 
The number the agent transfered the call to is not shown at all, instead
you get the number of the queue from where he received the call,
This makes it impossible to tell to what number the call was transfered to
as there are no more logs with the same uniqueid to tell us what happened
with the call.
====================================================================== 

---------------------------------------------------------------------- 
 (0121322) Rami (reporter) - 2010-05-04 02:39
 https://issues.asterisk.org/view.php?id=17243#c121322 
---------------------------------------------------------------------- 
I have been able to resolve the Issue myself
by changing this line in the application app_queue.c (queue_transfer_fixup
function):

	ast_queue_log(qe->parent->name, qe->chan->uniqueid, member->membername,
"TRANSFER", "%s|%s|%ld|%ld",
				new_chan->exten, new_chan->context, (long) (callstart - qe->start),
				(long) (time(NULL) - callstart));

to:

	ast_queue_log(qe->parent->name, qe->chan->uniqueid, member->membername,
"TRANSFER", "%s|%s|%ld|%ld",
				S_OR(qe->chan->cid.cid_num, "(N/A)"), new_chan->context, (long)
(callstart - qe->start),
				(long) (time(NULL) - callstart)); 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-05-04 02:39 Rami           Note Added: 0121322                          
======================================================================