[asterisk-bugs] [Asterisk 0014577]: [patch] FXO channels "hookstate" incorrect on startup

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14577 
====================================================================== 
Reported By:                jkroon
Assigned To:                sruffell
====================================================================== 
Project:                    Asterisk
Issue ID:                   14577
Category:                   Channels/chan_dahdi
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     confirmed
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-03-01 16:16 CST
Last Modified:              2010-03-30 03:47 CDT
====================================================================== 
Summary:                    [patch] FXO channels "hookstate" incorrect on
startup
Description: 
Referencing bug 13786 (http://bugs.digium.com/view.php?id=13786) which
attempts to work around an underlying problem in userspace (chan_dahdi). 
The issue seems to be (as described by tzafrir):

It seems to expose a bug(?) in zaptel/dahdi where chan->rxhooksig is set
to RX_HOOKSIG_INITIAL at the end of chanconfig() which leaves the channel's
state there "uninitialized" and even if the channel driver knows better it
cannot override this decision. But I'm not sure what's the intended
behaviour, so I avoid a seperate bug report on that for now.

This is manifested in that I cannot make outbound calls on an FXO card
(Using FXSKS signalling) until I've received an incoming call resetting the
hookstate to offhook (A single ring is good enough), or alternatively,
disconnecting and reconnecting the telephone line.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
has duplicate       0015429 After the system reboot calls do not go...
====================================================================== 

---------------------------------------------------------------------- 
 (0119994) frawd (reporter) - 2010-03-30 03:47
 https://issues.asterisk.org/view.php?id=14577#c119994 
---------------------------------------------------------------------- 
I had forgotten that there are other things that FXO (FXS signalled)
ports... The uploaded fix puts back the #ifdef in the right place and
clears up the comments. I think it completely resolves the issue.

tzafrir: I make the assumption that for CAS channels (FXO channel banks),
the "onhook"/"offhook" does not necessarily mean something about the
battery state, so even if DAHDI_CHECK_HOOKSTATE is defined, it returns 1.
This hook state would only be taken into account for non-CAS channels. It
is the opposite of your patch so your comments on this would be great.

Note: If one wants to define DAHDI_CHECK_HOOKSTATE, he still needs to
apply sruffell's dahdi_base patch into dahdi to have a resolve the initial
hookstate bug on non-CAS channels (wctdm cards and similar). 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-03-30 03:47 frawd          Note Added: 0119994                          
======================================================================