[asterisk-bugs] [Asterisk 0017094]: unportable shell in safe_asterisk

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17094 
====================================================================== 
Reported By:                stuarth
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17094
Category:                   Core/Portability
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           1.6.0.26 
JIRA:                       SWP-1174 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-03-25 07:08 CDT
Last Modified:              2010-03-25 12:02 CDT
====================================================================== 
Summary:                    unportable shell in safe_asterisk
Description: 
"function message() {" is unportable, I think it should be replaced with
just "message() {" as was already done for run_asterisk().
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
duplicate of        0013111 [patch] /usr/sbin/safe_asterisk: 31: Sy...
====================================================================== 

---------------------------------------------------------------------- 
 (0119904) svnbot (reporter) - 2010-03-25 12:02
 https://issues.asterisk.org/view.php?id=17094#c119904 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 254539

_U  branches/1.6.0/
U   branches/1.6.0/contrib/scripts/safe_asterisk

------------------------------------------------------------------------
r254539 | lmadsen | 2010-03-25 12:02:17 -0500 (Thu, 25 Mar 2010) | 28
lines

Make safe_asterisk work on dash/sh/bash etc.

Merged from the change to trunk via issue
https://issues.asterisk.org/view.php?id=13111. For some reason
the changes there were only done on trunk, and thus were available
for 1.6.1 and 1.6.2 when they were branched. Because this change is
available on both 1.6.1 and 1.6.2, it makes sense to allow it on the
1.6.0 branch as well.

(closes issue https://issues.asterisk.org/view.php?id=17094)
Reported by: stuarth

Much thanks to Tilghman and Sean Bright for the help on this merge.

Merged revisions 135061 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r135061 | mvanbaak | 2008-08-01 07:17:33 -0500 (Fri, 01 Aug 2008) | 8
lines
  
  Make safe_asterisk work on dash/sh/bash etc.
  
  (closes issue https://issues.asterisk.org/view.php?id=13111)
  Reported by: pabelanger
  Patches:
        2008071901_issue13111_safe_asterisk.diff uploaded by mvanbaak
(license 7)
  Tested by: mvanbaak, pabelanger
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=254539 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-03-25 12:02 svnbot         Checkin                                      
2010-03-25 12:02 svnbot         Note Added: 0119904                          
======================================================================