[asterisk-bugs] [Asterisk 0014577]: [patch] FXO channels "hookstate" incorrect on startup

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14577 
====================================================================== 
Reported By:                jkroon
Assigned To:                sruffell
====================================================================== 
Project:                    Asterisk
Issue ID:                   14577
Category:                   Channels/chan_dahdi
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     confirmed
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-03-01 16:16 CST
Last Modified:              2010-03-19 20:48 CDT
====================================================================== 
Summary:                    [patch] FXO channels "hookstate" incorrect on
startup
Description: 
Referencing bug 13786 (http://bugs.digium.com/view.php?id=13786) which
attempts to work around an underlying problem in userspace (chan_dahdi). 
The issue seems to be (as described by tzafrir):

It seems to expose a bug(?) in zaptel/dahdi where chan->rxhooksig is set
to RX_HOOKSIG_INITIAL at the end of chanconfig() which leaves the channel's
state there "uninitialized" and even if the channel driver knows better it
cannot override this decision. But I'm not sure what's the intended
behaviour, so I avoid a seperate bug report on that for now.

This is manifested in that I cannot make outbound calls on an FXO card
(Using FXSKS signalling) until I've received an incoming call resetting the
hookstate to offhook (A single ring is good enough), or alternatively,
disconnecting and reconnecting the telephone line.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
has duplicate       0015429 After the system reboot calls do not go...
====================================================================== 

---------------------------------------------------------------------- 
 (0119624) frawd (reporter) - 2010-03-19 20:48
 https://issues.asterisk.org/view.php?id=14577#c119624 
---------------------------------------------------------------------- 
I think the patch I just uploaded puts the #ifdef back where it should be,
and it would resolve the "available()" issue on default compile (when
DAHDI_CHECK_HOOKSTATE isn't defined). Even if the initial hookstate is
wrong, the outgoing calls can still go through. It should then resolve the
effects of this bug but not the bug itself.

Now sruffell's dahdi_base patch makes the initial hookstate correct and
allows me to define DAHDI_CHECK_HOOKSTATE. I need it to prevent calls going
through analog FXO ports with a driver that doesn't set alarms when no
battery is on the line (Sangoma wanpipe). Other than that it's not really
needed and this check should be deprecated in favour of alarms.

Would this be the right approach? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-03-19 20:48 frawd          Note Added: 0119624                          
======================================================================