[asterisk-bugs] [Asterisk 0015811]: [patch] dtmf creating double digits if received out of order

[Asterisk Bug Tracker]

The following issue is now READY FOR REVIEW. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15811 
====================================================================== 
Reported By:                eeman
Assigned To:                mmichelson
====================================================================== 
Project:                    Asterisk
Issue ID:                   15811
Category:                   Core/RTP
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     ready for review
Asterisk Version:           1.4.26.1 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-09-01 20:17 CDT
Last Modified:              2010-03-18 10:49 CDT
====================================================================== 
Summary:                    [patch] dtmf creating double digits if received out
of order
Description: 
Have an Adtran TotalAccess 916e with MLPPP bonded t1's registering with sip
to an asterisk PBX (Asterisk 1.4.26.1 on centos 5.2). Sip channels set up
for dtmfmode RFC2833 and codec is g729. The devices calling through the
adtran are unable to send DTMF correctly to remove IVR's or even to
applications on the Asterisk PBX 99% of the time. I created a ticket and
capture with Adtran and their response was that perhaps asterisk cannot
handle out of order DTMF packets. Their response is in additional
information.
====================================================================== 

---------------------------------------------------------------------- 
 (0119548) mmichelson (administrator) - 2010-03-18 10:49
 https://issues.asterisk.org/view.php?id=15811#c119548 
---------------------------------------------------------------------- 
Just thought I'd let you know how things are progressing here.

First off, thanks for testing the patch, and I'm glad things appear to be
working well now.

I've posted a code review at https://reviewboard.asterisk.org/r/558 which
is a patch against Asterisk trunk. The patch fixes this issue plus a couple
of other RFC 2833 DTMF issues I noticed while looking at the code. In
addition, I wrote a test script which exercises the changes and have posted
the script for review at https://reviewboard.asterisk.org/r/560

Once I get those reviews signed off, I will be able to commit the changes
and get this issue closed out. I've marked this as being "ready for review"
since there are code review requests posted now. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-03-18 10:49 mmichelson     Note Added: 0119548                          
2010-03-18 10:49 mmichelson     Status                   ready for testing =>
ready for review
======================================================================