[asterisk-bugs] [Asterisk 0017044]: [patch] SDP c and o lines contain the wrong IP address when using an externally mapped IP(extern{ip, host})

[Asterisk Bug Tracker]

The following issue has been UPDATED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17044 
====================================================================== 
Reported By:                ebroad
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17044
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     confirmed
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:           https://reviewboard.asterisk.org/r/566/ 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-03-16 15:45 CDT
Last Modified:              2010-03-16 21:01 CDT
====================================================================== 
Summary:                    [patch] SDP c and o lines contain the wrong IP
address when using an externally mapped IP(extern{ip,host})
Description: 
The problem stems from a call to ast_rtp_instance_get_local_address() in
chan_sip.c in get_our_media_address(). ast_rtp_instance_get_local_address()
will always return the internal IP address of the Asterisk machine, which
could pose a problem when using NAT. 

A simple solution would be to override {v,t}sin->sin_addr in
get_our_media_address() with p->ourip.sin_addr.s_addr if it is different,
though I don't know what that might break.  
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-03-16 21:01 ebroad         Reviewboard Link          =>
https://reviewboard.asterisk.org/r/566/
======================================================================