[asterisk-bugs] [Asterisk 0016655]: [patch] Double fields in SQL query

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16655 
====================================================================== 
Reported By:                Yarik_rad
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16655
Category:                   CDR/cdr_pgsql
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           1.6.0.21 
JIRA:                       SWP-780 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-01-20 04:48 CST
Last Modified:              2010-03-16 13:01 CDT
====================================================================== 
Summary:                    [patch] Double fields in SQL query
Description: 
Try to connect Asterisk server with PostgreSQl database I've double fields
in SQL quere send to datbase.

Here is log of database server:

COMMAND:  INSERT INTO cdr
("calldate","clid","src","dst","dcontext","channel","dstchannel","lastapp","lastdata","duration","billsec","disposition","amaflags",
"uniqueid","calldate","clid","src","dst","dcontext","channel","dstchannel","lastapp","lastdata","duration","billsec","disposition","amaflags","uniqueid","calldate",
"clid","src","dst","dcontext","channel","dstchannel","lastapp","lastdata","duration","billsec","disposition","amaflags","accountcode","uniqueid","userfield",
"calldate","clid","src","dst","dcontext","channel","dstchannel","lastapp","lastdata","duration","billsec","disposition","amaflags","accountcode","uniqueid","userfield")
VALUES ('2010-01-20 13:43:16','"User714"
<714>','714','9060','kvartira','SIP/714-00000057','SIP/pstn-00000058','Dial','SIP/999060 at pstn',13,2,'ANSWERED',3,'1263984196.87',
'2010-01-20 13:43:16','"User714"
<714>','714','9060','kvartira','SIP/714-00000057','SIP/pstn-00000058','Dial','SIP/999060 at pstn',13,2,'ANSWERED',3,'1263984196.87',
'2010-01-20 13:43:16','"User714"
<714>','714','9060','kvartira','SIP/714-00000057','SIP/pstn-00000058','Dial','SIP/999060 at pstn',13,2,'ANSWERED',3,'','1263984196.87','',
'2010-01-20 13:43:16','"User714"
<714>','714','9060','kvartira','SIP/714-00000057','SIP/pstn-00000058','Dial','SIP/999060 at pstn',13,2,'ANSWERED',3,'','1263984196.87','')



====================================================================== 

---------------------------------------------------------------------- 
 (0119448) coolmig (reporter) - 2010-03-16 13:01
 https://issues.asterisk.org/view.php?id=16655#c119448 
---------------------------------------------------------------------- 
I modified the query to bring only the fields that are owned by the user
with what we are connecting to the database. I tested the query, and it
brings the correct fields (non duplicate) from the correct schema and table
where the user is the owner.

I've created a patch for the cdr_pgsql module with the changes. Feel free
to review the patch, it works flawlessly for me and is already inserting
records! But I did not test the case where we are not the owner of the
table, it surely would bring no fields.

Hope it solves the issue once for all! 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-03-16 13:01 coolmig        Note Added: 0119448                          
======================================================================