[asterisk-bugs] [Asterisk 0016965]: [patch] DBGet response does not end with a 'Complete' event

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16965 
====================================================================== 
Reported By:                rrb3942
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16965
Category:                   Core/ManagerInterface
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.4.29.1 
JIRA:                       SWP-1044 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-03-04 14:45 CST
Last Modified:              2010-03-11 14:49 CST
====================================================================== 
Summary:                    [patch] DBGet response does not end with a
'Complete' event
Description: 
DBGet returns its response as an event, but it does not send a 'Complete'
event.

For example take this Action -

Action: DBGet
Family: Foo
Key: bar
ActionID: 1

How it responds now -

Response: Success
Message: Result will follow
ActionID: 1

Event: DBGetResponse
Family: Foo
Key: bar
Value: sip123
ActionID: 1

How it should respond -

Response: Success
Message: Result will follow
ActionID: 1

Event: DBGetResponse
Family: Foo
Key: bar
Value: sip123
ActionID: 1

Event: DBGetComplete
ActionID: 1

This will bring DBGet in line with how other manager actions behave when
responding with events.
====================================================================== 

---------------------------------------------------------------------- 
 (0119283) rrb3942 (reporter) - 2010-03-11 14:49
 https://issues.asterisk.org/view.php?id=16965#c119283 
---------------------------------------------------------------------- 
I saw that some of the newer actions added in 1.6 started adding counters.
But I don't really understand what purpose they serve. In my opinion it
doesn't really help the receiving end at all.

The manager runs over TCP, so if a packet is lost/dropped/corrupted it
will be retransmitted and it will be re-assembled on the remote end in the
correct order before being passed up the networks stack. So, if you receive
the 'Complete' you have received all the responses.

Maybe I am missing something, a specific use case or something but it just
doesn't seem useful.
Granted it should be easy to add, the question is just why? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-03-11 14:49 rrb3942        Note Added: 0119283                          
======================================================================