[asterisk-bugs] [Asterisk 0016917]: jblog=yes does not create jblog like expected

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16917 
====================================================================== 
Reported By:                Artem
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16917
Category:                   Core/Jitterbuffer
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           1.6.2.4 
JIRA:                       SWP-1001 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-02-26 12:10 CST
Last Modified:              2010-03-10 12:25 CST
====================================================================== 
Summary:                    jblog=yes does not create jblog like expected
Description: 
Hello,

when enabling jitterbuffer and setting

jblog=yes

then the logfile is not created like expected. Insted this error message
is logged:

[Feb 26 19:06:29] WARNING[27123]: abstract_jb.c:469 create_jb: Failed to
put first frame in the jitterbuffer on channel 'SCCP/5555-00000001'
[Feb 26 19:06:29] ERROR[27123]: abstract_jb.c:507 create_jb: Failed to
create frame log file with pathname
'/tmp/ast_adaptive_jb_SIP#xxxxx-00000005--SCCP#5555-00000001.log': Success

It has nothing to do with SCCP. This problem can also be reproduced with
other channel drivers supporting jitterbuffer.

It has also nothing to do with permissions as this can also be reproduced
when running asterisk as root.
====================================================================== 

---------------------------------------------------------------------- 
 (0119232) svnbot (reporter) - 2010-03-10 12:25
 https://issues.asterisk.org/view.php?id=16917#c119232 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 251631

U   trunk/main/abstract_jb.c

------------------------------------------------------------------------
r251631 | jpeeler | 2010-03-10 12:25:18 -0600 (Wed, 10 Mar 2010) | 14
lines

Fix jitterbuffer logging not creating logfiles.

Three changes made here:
1) Do not fail if a previous log does not exist (in fact, this is probably
expected).
2) Ensure that the file descriptor to write to gets assigned properly. I
am at
a loss as to why assigning safe_fd outside the if fixes this, but it makes
the if statement slightly less complicated anyway.
3) Move up the failure message so that the errno of the failure is not
overwritten by fclose.

(closes issue https://issues.asterisk.org/view.php?id=16917)
Reported by: Artem

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=251631 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-03-10 12:25 svnbot         Checkin                                      
2010-03-10 12:25 svnbot         Note Added: 0119232                          
======================================================================