[asterisk-bugs] [Asterisk 0016557]: [patch] Asterisk produces malformed email files for voicemail

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16557 
====================================================================== 
Reported By:                jcovert
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16557
Category:                   Applications/app_voicemail
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.6.0.20 
JIRA:                       SWP-954 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-01-06 09:29 CST
Last Modified:              2010-03-08 15:53 CST
====================================================================== 
Summary:                    [patch] Asterisk produces malformed email files for
voicemail
Description: 
Asterisk is inserting an extra <cr> into the voicemail attachment.  This
causes some mail relays to fail to forward the SMTP message.

While the correct line termination in an SMTP message IS <cr><lf>, the
conversion from the Unix <lf> line terminator to <cr><lf> is handled by
sendmail.  When sendmail gets a file which (mostly) has just <lf>
terminators up until the attachment, it sees the <cr><lf> in the attachment
portion and converts that to <cr><cr><lf>.  This confuses some mail relays
down the road and prevents delivery.

This is a problem in all versions, and the fix is trivial:

At line 418 of the current head, there appears

#define eol "\r\n" 

this should just be "\n"

The resulting SMTP message will still have <cr><lf> once it has been
processed by the sendmail command.

"eol" is used ONLY in "ochar" which is used only in "base_encode".

====================================================================== 

---------------------------------------------------------------------- 
 (0119162) tilghman (administrator) - 2010-03-08 15:53
 https://issues.asterisk.org/view.php?id=16557#c119162 
---------------------------------------------------------------------- 
I've uploaded a replacement patch, both for 1.4 and 1.6.0, that covers an
additional situation, where if the voicemail notification had a custom
message, then the line terminators could have been inconsistent, when the
storage method was IMAP.

Also, since ENDL is used elsewhere in the file, and since eol was going to
be made equivalent to ENDL, I replaced the 'eol' definitions with ENDL
definitions. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-03-08 15:53 tilghman       Note Added: 0119162                          
======================================================================