[asterisk-bugs] [Asterisk 0016685]: [patch] Configured CFLAGS/LDFLAGS are used by main, but not by modules built out of tree

[Asterisk Bug Tracker]

The following issue has been UPDATED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16685 
====================================================================== 
Reported By:                pprindeville
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16685
Category:                   Core/BuildSystem
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Target Version:             1.6.0.26
Asterisk Version:           SVN 
JIRA:                       SWP-789 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-01-24 22:09 CST
Last Modified:              2010-03-06 18:47 CST
====================================================================== 
Summary:                    [patch] Configured CFLAGS/LDFLAGS are used by main,
but not by modules built out of tree
Description: 
The patch supplied by Kevin in:

http://svn.asterisk.org/svn-view/asterisk?view=rev&rev=214696

doesn't include Makefile.rules, so out-of-tree modules (which use
Makefile.moddir_rules which includes Makefile.rules) won't have properly
initialized values for _ASTCFLAGS and ASTLDFLAGS.

====================================================================== 

---------------------------------------------------------------------- 
 (0119058) pprindeville (reporter) - 2010-03-06 18:47
 https://issues.asterisk.org/view.php?id=16685#c119058 
---------------------------------------------------------------------- 
"I really don't see why this needs a review on our part. From our
perspective, if code is under a license where it could be linked to
Asterisk, it might as well be contributed to Asterisk, where it could exist
in-tree. So there doesn't appear to be a good reason either for modules to
exist outside of the tree or for us to support such a beast."

The corollary to that reasoning, of course, is that you're not making it
possible for users who wish to build code that requires a different license
to do so (out-of-tree).  For instance, if they wanted to use a resource or
feature that required non-GPL licensing (such as libnfconntrack, or an MP3
codec). 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-03-06 18:47 pprindeville   Note Added: 0119058                          
2010-03-06 18:47 pprindeville   Status                   closed => new       
2010-03-06 18:47 pprindeville   Resolution               no change required =>
reopened
======================================================================