[asterisk-bugs] [Asterisk 0016906]: [patch] moh files install under datadir, at runtime: under varlibdir

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16906 
====================================================================== 
Reported By:                tzafrir
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16906
Category:                   Resources/res_musiconhold
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           1.6.2.3-rc2 
JIRA:                       SWP-980 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-02-25 15:45 CST
Last Modified:              2010-03-06 15:06 CST
====================================================================== 
Summary:                    [patch] moh files install under datadir, at runtime:
under varlibdir
Description: 
In sounds/Makefile , the moh files are installed to:

  MOH_DIR:=$(DESTDIR)$(ASTDATADIR)/moh

However in res/res_musiconhold.c , in moh_scan_files we have (1.6.2) -

        if (class->dir[0] != '/') {
                ast_copy_string(dir_path, ast_config_AST_VAR_DIR,
sizeof(dir_path));
                strncat(dir_path, "/", sizeof(dir_path) - 1);
                strncat(dir_path, class->dir, sizeof(dir_path) - 1);


Thus if astdatadir != astvarrundir , res_musiconh will fail to find the
files with the default configuration.
====================================================================== 

---------------------------------------------------------------------- 
 (0119053) tzafrir (manager) - 2010-03-06 15:06
 https://issues.asterisk.org/view.php?id=16906#c119053 
---------------------------------------------------------------------- 
I decided to patch res_musiconhold.c .

Note that this bug was introduced when support for relative pathes in
musiconhold.conf was added (r149917 , Nov. 2008). 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-03-06 15:06 tzafrir        Note Added: 0119053                          
======================================================================